minidump/minidump_exception_writer.h - Issue 703223003: Add MinidumpFileWriter::InitializeFromSnapshot() and its tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_exception_writer.h

Issue 703223003: Add MinidumpFileWriter::InitializeFromSnapshot() and its tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_crashpad_info_init_from_snapshot

Patch Set: Address review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_exception_writer.h

diff --git a/minidump/minidump_exception_writer.h b/minidump/minidump_exception_writer.h

index 1578ad585b5ae23a58a9fd45076a6f5f1bc3fe43..a094a4714f0c7653b0d67fbe82136d0789bbed5a 100644

--- a/minidump/minidump_exception_writer.h

+++ b/minidump/minidump_exception_writer.h

@@ -49,7 +49,7 @@ class MinidumpExceptionWriter final : public internal::MinidumpStreamWriter {

//! this method, and it is not normally necessary to call any mutator

//! methods after this method.

void InitializeFromSnapshot(const ExceptionSnapshot* exception_snapshot,

- const MinidumpThreadIDMap* thread_id_map);

+ const MinidumpThreadIDMap& thread_id_map);

//! \brief Arranges for MINIDUMP_EXCEPTION_STREAM::ThreadContext to point to

//! the CPU context to be written by \a context.

« no previous file with comments | « no previous file | minidump/minidump_exception_writer.cc » ('j') | no next file with comments »