Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 702603004: Renamed DISABLE_BASIC_PRINTING and ENABLE_FULL_PRINTING. (Closed)

Created:
6 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang, jschuh, brettw
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, mazda+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-factored printing defines and build configs. Renamed DISABLE_BASIC_PRINTING to ENABLE_BASIC_PRINTING. Renamed ENABLE_FULL_PRINTING to ENABLE_PRINT_PREVIEW. BUG=430281 Committed: https://crrev.com/e29991c62a63bbce344e597306dab8150c67b532 Cr-Commit-Position: refs/heads/master@{#302868}

Patch Set 1 #

Patch Set 2 : Tue Nov 4 16:01:27 PST 2014 #

Total comments: 6

Patch Set 3 : Tue Nov 4 16:12:32 PST 2014 #

Patch Set 4 : Tue Nov 4 17:22:50 PST 2014 #

Total comments: 2

Patch Set 5 : Tue Nov 4 17:29:56 PST 2014 #

Patch Set 6 : Tue Nov 4 17:44:58 PST 2014 #

Patch Set 7 : Tue Nov 4 17:47:33 PST 2014 #

Patch Set 8 : Wed Nov 5 00:06:05 PST 2014 #

Patch Set 9 : Wed Nov 5 02:31:54 PST 2014 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -225 lines) Patch
M athena/extensions/chrome/athena_chrome_app_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 2 chunks +5 lines, -5 lines 2 comments Download
M build/config/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_dll.rc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/task_manager/printing_information.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/location_bar/origin_chip_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_utility_printing_messages.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/print_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/printing_handler.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/utility/printing_handler.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/renderer_context_menu/context_menu_content_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_print_settings_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (4 generated)
Vitaly Buka (NO REVIEWS)
6 years, 1 month ago (2014-11-05 00:00:58 UTC) #2
Vitaly Buka (NO REVIEWS)
6 years, 1 month ago (2014-11-05 00:01:21 UTC) #4
Vitaly Buka (NO REVIEWS)
+jschuh for chrome\common\chrome_utility_printing_messages.h chrome\common\print_messages.h
6 years, 1 month ago (2014-11-05 00:02:37 UTC) #6
Lei Zhang
https://codereview.chromium.org/702603004/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/702603004/diff/20001/build/common.gypi#newcode495 build/common.gypi:495: 'enable_printing%': 1, Please update the comment here. https://codereview.chromium.org/702603004/diff/20001/build/common.gypi#newcode2929 build/common.gypi:2929: ...
6 years, 1 month ago (2014-11-05 00:14:45 UTC) #7
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/702603004/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/702603004/diff/20001/build/common.gypi#newcode495 build/common.gypi:495: 'enable_printing%': 1, On 2014/11/05 00:14:45, Lei Zhang wrote: > ...
6 years, 1 month ago (2014-11-05 01:22:08 UTC) #8
Vitaly Buka (NO REVIEWS)
I have noticed couple of places where cloud print connector linked to print preview conditions. ...
6 years, 1 month ago (2014-11-05 01:28:52 UTC) #9
Lei Zhang
lgtm, though I only spot checked the .cc / .h files. https://codereview.chromium.org/702603004/diff/50001/build/common.gypi File build/common.gypi (right): ...
6 years, 1 month ago (2014-11-05 01:38:10 UTC) #10
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/702603004/diff/50001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/702603004/diff/50001/build/common.gypi#newcode494 build/common.gypi:494: # 2 enables printing with print privew On 2014/11/05 ...
6 years, 1 month ago (2014-11-05 01:54:30 UTC) #11
Vitaly Buka (NO REVIEWS)
maybe better to switch from printing_mode just to (enable_print_preview + enable_basic_printing) it's going to be ...
6 years, 1 month ago (2014-11-05 05:31:02 UTC) #12
Vitaly Buka (NO REVIEWS)
Moved build files changes to https://codereview.chromium.org/702023002/
6 years, 1 month ago (2014-11-05 08:32:33 UTC) #13
jschuh
ipc security lgtm: mechanical renames
6 years, 1 month ago (2014-11-05 16:40:17 UTC) #14
brettw
https://codereview.chromium.org/702603004/diff/150001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/702603004/diff/150001/build/common.gypi#newcode2927 build/common.gypi:2927: 'defines': ['ENABLE_PRINTING=1', 'ENABLE_BASIC_PRINTING=1'], So does ENABLE_PRINTING have the same ...
6 years, 1 month ago (2014-11-05 18:02:11 UTC) #15
brettw
6 years, 1 month ago (2014-11-05 18:02:58 UTC) #16
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/702603004/diff/150001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/702603004/diff/150001/build/common.gypi#newcode2927 build/common.gypi:2927: 'defines': ['ENABLE_PRINTING=1', 'ENABLE_BASIC_PRINTING=1'], it's would be ENABLE_PRINTING = (ENABLE_PRINT_PREVIEW ...
6 years, 1 month ago (2014-11-05 19:14:49 UTC) #17
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/702603004/diff/150001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/702603004/diff/150001/build/common.gypi#newcode2927 build/common.gypi:2927: 'defines': ['ENABLE_PRINTING=1', 'ENABLE_BASIC_PRINTING=1'], it's would be ENABLE_PRINTING = (ENABLE_PRINT_PREVIEW ...
6 years, 1 month ago (2014-11-05 19:14:50 UTC) #18
brettw
lgtm
6 years, 1 month ago (2014-11-05 19:35:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702603004/150001
6 years, 1 month ago (2014-11-05 19:37:27 UTC) #21
commit-bot: I haz the power
Committed patchset #9 (id:150001)
6 years, 1 month ago (2014-11-05 21:15:23 UTC) #22
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 21:17:22 UTC) #23
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/e29991c62a63bbce344e597306dab8150c67b532
Cr-Commit-Position: refs/heads/master@{#302868}

Powered by Google App Engine
This is Rietveld 408576698