Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: build/common.gypi

Issue 702023002: Renamed enable_printing and printing_mode in *.gyp* and .*gn* files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wed Nov 5 03:20:34 PST 2014 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 480
481 # Whether to back up data before sync. 481 # Whether to back up data before sync.
482 'enable_pre_sync_backup%': 0, 482 'enable_pre_sync_backup%': 0,
483 483
484 # Enable Chrome browser extensions 484 # Enable Chrome browser extensions
485 'enable_extensions%': 1, 485 'enable_extensions%': 1,
486 486
487 # Enable Google Now. 487 # Enable Google Now.
488 'enable_google_now%': 1, 488 'enable_google_now%': 1,
489 489
490 # Enable printing support and UI. This variable is used to configure 490 # Enable basic printing support and UI.
491 # which parts of printing will be built. 0 disables printing completely, 491 'enable_basic_printing%': 1,
492 # 1 enables it fully, and 2 enables only the codepath to generate a 492
493 # Metafile (e.g. usually a PDF or EMF) and disables print preview, cloud 493 # Enable printing with print preview.
brettw 2014/11/05 18:02:52 Can you comment here "requires basic printing to b
Vitaly Buka (NO REVIEWS) 2014/11/05 19:17:47 It does not. The point is to have them independent
brettw 2014/11/05 19:25:23 Can you comment about that explicitly here then? J
Vitaly Buka (NO REVIEWS) 2014/11/05 21:50:03 Done.
494 # print, UI, etc. 494 'enable_print_preview%': 1,
495 'enable_printing%': 1,
496 495
497 # Set the version of CLD. 496 # Set the version of CLD.
498 # 0: Don't specify the version. This option is for the Finch testing. 497 # 0: Don't specify the version. This option is for the Finch testing.
499 # 1: Use only CLD1. 498 # 1: Use only CLD1.
500 # 2: Use only CLD2. 499 # 2: Use only CLD2.
501 'cld_version%': 2, 500 'cld_version%': 2,
502 501
503 # For CLD2, the size of the tables that should be included in the build 502 # For CLD2, the size of the tables that should be included in the build
504 # Only evaluated if cld_version == 2 or if building the CLD2 dynamic data 503 # Only evaluated if cld_version == 2 or if building the CLD2 dynamic data
505 # tool explicitly. 504 # tool explicitly.
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 'enable_extensions%': 0, 762 'enable_extensions%': 0,
764 'enable_google_now%': 0, 763 'enable_google_now%': 0,
765 'cld_version%': 1, 764 'cld_version%': 1,
766 'enable_spellcheck%': 0, 765 'enable_spellcheck%': 0,
767 'enable_themes%': 0, 766 'enable_themes%': 0,
768 'remoting%': 0, 767 'remoting%': 0,
769 'arm_neon%': 0, 768 'arm_neon%': 0,
770 'arm_neon_optional%': 1, 769 'arm_neon_optional%': 1,
771 'native_discardable_memory%': 1, 770 'native_discardable_memory%': 1,
772 'native_memory_pressure_signals%': 1, 771 'native_memory_pressure_signals%': 1,
773 'enable_printing%': 2, 772 'enable_basic_printing%': 1,
773 'enable_print_preview%': 0,
774 'enable_task_manager%':0, 774 'enable_task_manager%':0,
775 'video_hole%': 1, 775 'video_hole%': 1,
776 }], 776 }],
777 777
778 # Android OS includes support for proprietary codecs regardless of 778 # Android OS includes support for proprietary codecs regardless of
779 # building Chromium or Google Chrome. We also ship Google Chrome and 779 # building Chromium or Google Chrome. We also ship Google Chrome and
780 # Chromecast with proprietary codecs. 780 # Chromecast with proprietary codecs.
781 ['OS=="android" or branding=="Chrome" or chromecast==1', { 781 ['OS=="android" or branding=="Chrome" or chromecast==1', {
782 'proprietary_codecs%': 1, 782 'proprietary_codecs%': 1,
783 }, { 783 }, {
(...skipping 18 matching lines...) Expand all
802 802
803 ['OS=="android"', { 803 ['OS=="android"', {
804 'enable_webrtc%': 1, 804 'enable_webrtc%': 1,
805 }], 805 }],
806 806
807 ['OS=="ios"', { 807 ['OS=="ios"', {
808 'disable_ftp_support%': 1, 808 'disable_ftp_support%': 1,
809 'enable_extensions%': 0, 809 'enable_extensions%': 0,
810 'enable_google_now%': 0, 810 'enable_google_now%': 0,
811 'cld_version%': 1, 811 'cld_version%': 1,
812 'enable_printing%': 0, 812 'enable_basic_printing%': 0,
813 'enable_print_preview%': 0,
813 'enable_session_service%': 0, 814 'enable_session_service%': 0,
814 'enable_themes%': 0, 815 'enable_themes%': 0,
815 'enable_webrtc%': 0, 816 'enable_webrtc%': 0,
816 'notifications%': 0, 817 'notifications%': 0,
817 'remoting%': 0, 818 'remoting%': 0,
818 'safe_browsing%': 0, 819 'safe_browsing%': 0,
819 'enable_managed_users%': 0, 820 'enable_managed_users%': 0,
820 'enable_task_manager%': 0, 821 'enable_task_manager%': 0,
821 'use_system_libcxx%': 1, 822 'use_system_libcxx%': 1,
822 'support_pre_M6_history_database%': 0, 823 'support_pre_M6_history_database%': 0,
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
972 # TODO(dpranke): http://crbug.com/266155 . 973 # TODO(dpranke): http://crbug.com/266155 .
973 ['OS=="android"', { 974 ['OS=="android"', {
974 'v8_optimized_debug%': 1, 975 'v8_optimized_debug%': 1,
975 }, { 976 }, {
976 'v8_optimized_debug%': 2, 977 'v8_optimized_debug%': 2,
977 }], 978 }],
978 979
979 # Disable various features by default on embedded. 980 # Disable various features by default on embedded.
980 ['embedded==1', { 981 ['embedded==1', {
981 'remoting%': 0, 982 'remoting%': 0,
982 'enable_printing%': 0, 983 'enable_basic_printing%': 0,
984 'enable_print_preview%': 0,
983 }], 985 }],
984 986
985 # By default, use ICU data file (icudtl.dat) on all platforms 987 # By default, use ICU data file (icudtl.dat) on all platforms
986 # except when building Android WebView or Chromecast. 988 # except when building Android WebView or Chromecast.
987 # TODO(jshin): Handle 'use_system_icu' on Linux (Chromium). 989 # TODO(jshin): Handle 'use_system_icu' on Linux (Chromium).
988 # Set the data reduction proxy origin for Android Webview. 990 # Set the data reduction proxy origin for Android Webview.
989 ['android_webview_build==0 and android_webview_telemetry_build==0 and ch romecast==0', { 991 ['android_webview_build==0 and android_webview_telemetry_build==0 and ch romecast==0', {
990 'icu_use_data_file_flag%' : 1, 992 'icu_use_data_file_flag%' : 1,
991 }, { 993 }, {
992 'icu_use_data_file_flag%' : 0, 994 'icu_use_data_file_flag%' : 0,
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
1168 'enable_prod_wallet_service%': '<(enable_prod_wallet_service)', 1170 'enable_prod_wallet_service%': '<(enable_prod_wallet_service)',
1169 'enable_background%': '<(enable_background)', 1171 'enable_background%': '<(enable_background)',
1170 'linux_use_bundled_gold%': '<(linux_use_bundled_gold)', 1172 'linux_use_bundled_gold%': '<(linux_use_bundled_gold)',
1171 'linux_use_bundled_binutils%': '<(linux_use_bundled_binutils)', 1173 'linux_use_bundled_binutils%': '<(linux_use_bundled_binutils)',
1172 'linux_use_gold_flags%': '<(linux_use_gold_flags)', 1174 'linux_use_gold_flags%': '<(linux_use_gold_flags)',
1173 'linux_use_debug_fission%': '<(linux_use_debug_fission)', 1175 'linux_use_debug_fission%': '<(linux_use_debug_fission)',
1174 'use_canvas_skia%': '<(use_canvas_skia)', 1176 'use_canvas_skia%': '<(use_canvas_skia)',
1175 'test_isolation_mode%': '<(test_isolation_mode)', 1177 'test_isolation_mode%': '<(test_isolation_mode)',
1176 'test_isolation_outdir%': '<(test_isolation_outdir)', 1178 'test_isolation_outdir%': '<(test_isolation_outdir)',
1177 'test_isolation_fail_on_missing': '<(test_isolation_fail_on_missing)', 1179 'test_isolation_fail_on_missing': '<(test_isolation_fail_on_missing)',
1178 'enable_printing%': '<(enable_printing)', 1180 'enable_basic_printing%': '<(enable_basic_printing)',
1181 'enable_print_preview%': '<(enable_print_preview)',
1179 'enable_spellcheck%': '<(enable_spellcheck)', 1182 'enable_spellcheck%': '<(enable_spellcheck)',
1180 'enable_google_now%': '<(enable_google_now)', 1183 'enable_google_now%': '<(enable_google_now)',
1181 'cld_version%': '<(cld_version)', 1184 'cld_version%': '<(cld_version)',
1182 'cld2_table_size%': '<(cld2_table_size)', 1185 'cld2_table_size%': '<(cld2_table_size)',
1183 'cld2_data_source%': '<(cld2_data_source)', 1186 'cld2_data_source%': '<(cld2_data_source)',
1184 'enable_captive_portal_detection%': '<(enable_captive_portal_detection)', 1187 'enable_captive_portal_detection%': '<(enable_captive_portal_detection)',
1185 'disable_file_support%': '<(disable_file_support)', 1188 'disable_file_support%': '<(disable_file_support)',
1186 'disable_ftp_support%': '<(disable_ftp_support)', 1189 'disable_ftp_support%': '<(disable_ftp_support)',
1187 'use_icu_alternatives_on_android%': '<(use_icu_alternatives_on_android)', 1190 'use_icu_alternatives_on_android%': '<(use_icu_alternatives_on_android)',
1188 'enable_task_manager%': '<(enable_task_manager)', 1191 'enable_task_manager%': '<(enable_task_manager)',
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
2089 'clang_xcode%': 1, 2092 'clang_xcode%': 1,
2090 }], 2093 }],
2091 ], 2094 ],
2092 }], 2095 }],
2093 ['enable_extensions==1', { 2096 ['enable_extensions==1', {
2094 'grit_defines': ['-D', 'enable_extensions'], 2097 'grit_defines': ['-D', 'enable_extensions'],
2095 }], 2098 }],
2096 ['enable_plugins!=0', { 2099 ['enable_plugins!=0', {
2097 'grit_defines': ['-D', 'enable_plugins'], 2100 'grit_defines': ['-D', 'enable_plugins'],
2098 }], 2101 }],
2099 ['enable_printing!=0', { 2102 ['enable_basic_printing==1 or enable_print_preview==1', {
2100 'grit_defines': ['-D', 'enable_printing'], 2103 'grit_defines': ['-D', 'enable_printing'],
2101 }], 2104 }],
2102 ['enable_printing==1', { 2105 ['enable_print_preview==1', {
2103 'grit_defines': ['-D', 'enable_print_preview'], 2106 'grit_defines': ['-D', 'enable_print_preview'],
2104 }], 2107 }],
2105 ['enable_themes==1', { 2108 ['enable_themes==1', {
2106 'grit_defines': ['-D', 'enable_themes'], 2109 'grit_defines': ['-D', 'enable_themes'],
2107 }], 2110 }],
2108 ['enable_app_list==1', { 2111 ['enable_app_list==1', {
2109 'grit_defines': ['-D', 'enable_app_list'], 2112 'grit_defines': ['-D', 'enable_app_list'],
2110 }], 2113 }],
2111 ['enable_settings_app==1', { 2114 ['enable_settings_app==1', {
2112 'grit_defines': ['-D', 'enable_settings_app'], 2115 'grit_defines': ['-D', 'enable_settings_app'],
(...skipping 803 matching lines...) Expand 10 before | Expand all | Expand 10 after
2916 'defines': ['ENABLE_GOOGLE_NOW=1'], 2919 'defines': ['ENABLE_GOOGLE_NOW=1'],
2917 }], 2920 }],
2918 ['cld_version!=0', { 2921 ['cld_version!=0', {
2919 'defines': ['CLD_VERSION=<(cld_version)'], 2922 'defines': ['CLD_VERSION=<(cld_version)'],
2920 }], 2923 }],
2921 ['cld_version==2', { 2924 ['cld_version==2', {
2922 # This is used to populate the "CLD Data Source" field in: 2925 # This is used to populate the "CLD Data Source" field in:
2923 # chrome://translate-internals 2926 # chrome://translate-internals
2924 'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'], 2927 'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'],
2925 }], 2928 }],
2926 ['enable_printing!=0', { 2929 ['enable_basic_printing==1 or enable_print_preview==1', {
2927 'defines': ['ENABLE_PRINTING=1', 'ENABLE_BASIC_PRINTING=1'], 2930 'defines': ['ENABLE_PRINTING=1'],
brettw 2014/11/05 19:25:23 Can you also comment in common.gypi and in the GN
Vitaly Buka (NO REVIEWS) 2014/11/05 21:50:03 Done.
2928 }], 2931 }],
2929 ['enable_printing==1', { 2932 ['enable_print_preview==1', {
2930 'defines': ['ENABLE_PRINT_PREVIEW=1'], 2933 'defines': ['ENABLE_PRINT_PREVIEW=1'],
2931 }], 2934 }],
2935 ['enable_basic_printing==1', {
2936 'defines': ['ENABLE_BASIC_PRINTING=1'],
2937 }],
2932 ['enable_spellcheck==1', { 2938 ['enable_spellcheck==1', {
2933 'defines': ['ENABLE_SPELLCHECK=1'], 2939 'defines': ['ENABLE_SPELLCHECK=1'],
2934 }], 2940 }],
2935 ['enable_captive_portal_detection==1', { 2941 ['enable_captive_portal_detection==1', {
2936 'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'], 2942 'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'],
2937 }], 2943 }],
2938 ['enable_app_list==1', { 2944 ['enable_app_list==1', {
2939 'defines': ['ENABLE_APP_LIST=1'], 2945 'defines': ['ENABLE_APP_LIST=1'],
2940 }], 2946 }],
2941 ['enable_settings_app==1', { 2947 ['enable_settings_app==1', {
(...skipping 2946 matching lines...) Expand 10 before | Expand all | Expand 10 after
5888 # settings in target dicts. SYMROOT is a special case, because many other 5894 # settings in target dicts. SYMROOT is a special case, because many other
5889 # Xcode variables depend on it, including variables such as 5895 # Xcode variables depend on it, including variables such as
5890 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5896 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5891 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5897 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5892 # files to appear (when present) in the UI as actual files and not red 5898 # files to appear (when present) in the UI as actual files and not red
5893 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5899 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5894 # and therefore SYMROOT, needs to be set at the project level. 5900 # and therefore SYMROOT, needs to be set at the project level.
5895 'SYMROOT': '<(DEPTH)/xcodebuild', 5901 'SYMROOT': '<(DEPTH)/xcodebuild',
5896 }, 5902 },
5897 } 5903 }
OLDNEW
« no previous file with comments | « build/all.gyp ('k') | build/config/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698