Renamed DISABLE_BASIC_PRINTING and ENABLE_FULL_PRINTING.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 474 matching lines @@
       'enable_extensions%': 1,
 
       # Enable Google Now.
       'enable_google_now%': 1,
 
       # Enable printing support and UI. This variable is used to configure
       # which parts of printing will be built. 0 disables printing completely,
       # 1 enables it fully, and 2 enables only the codepath to generate a
       # Metafile (e.g. usually a PDF or EMF) and disables print preview, cloud
       # print, UI, etc.
       'enable_printing%': 1,

[Lei Zhang, 2014/11/05 00:14:45]

Please update the comment here.

[Vitaly Buka (NO REVIEWS), 2014/11/05 01:22:08]

Done.

 
       # Set the version of CLD.
       #   0: Don't specify the version. This option is for the Finch testing.
       #   1: Use only CLD1.
       #   2: Use only CLD2.
       'cld_version%': 2,
 
       # For CLD2, the size of the tables that should be included in the build
       # Only evaluated if cld_version == 2 or if building the CLD2 dynamic data
       # tool explicitly.
@@ skipping 2410 matching lines @@
         'defines': ['ENABLE_GOOGLE_NOW=1'],
       }],
       ['cld_version!=0', {
         'defines': ['CLD_VERSION=<(cld_version)'],
       }],
       ['cld_version==2', {
         # This is used to populate the "CLD Data Source" field in:
         # chrome://translate-internals
         'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'],
       }],
+      ['enable_printing!=1', {
+        'defines': ['ENABLE_PRINTING=1'],
+      }],
       ['enable_printing==1', {

[Lei Zhang, 2014/11/05 00:14:45]

This doesn't look right. It doesn't mention ENABLE_PRINT_PREVIEW for example.

[Vitaly Buka (NO REVIEWS), 2014/11/05 01:22:08]

Done.

-        'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],
-      }],
-      ['enable_printing==2', {
-        'defines': ['ENABLE_PRINTING=1'],
+        'defines': ['ENABLE_FULL_PRINTING=1'],
       }],
       ['enable_spellcheck==1', {
         'defines': ['ENABLE_SPELLCHECK=1'],
       }],
       ['enable_captive_portal_detection==1', {
         'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'],
       }],
       ['enable_app_list==1', {
         'defines': ['ENABLE_APP_LIST=1'],
       }],
@@ skipping 2947 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }