Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: build/common.gypi

Issue 702603004: Renamed DISABLE_BASIC_PRINTING and ENABLE_FULL_PRINTING. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wed Nov 5 02:31:54 PST 2014 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/extensions/chrome/athena_chrome_app_delegate.cc ('k') | build/config/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 91156ec1e85f9cdcef702490946ac6bbf3b4b1b6..aadd060625ead1e57f4a2b51bb94cd1ef73068cb 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2100,7 +2100,7 @@
'grit_defines': ['-D', 'enable_printing'],
}],
['enable_printing==1', {
- 'grit_defines': ['-D', 'enable_full_printing'],
+ 'grit_defines': ['-D', 'enable_print_preview'],
}],
['enable_themes==1', {
'grit_defines': ['-D', 'enable_themes'],
@@ -2923,11 +2923,11 @@
# chrome://translate-internals
'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'],
}],
- ['enable_printing==1', {
- 'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],
+ ['enable_printing!=0', {
+ 'defines': ['ENABLE_PRINTING=1', 'ENABLE_BASIC_PRINTING=1'],
brettw 2014/11/05 18:02:11 So does ENABLE_PRINTING have the same meaning as E
Vitaly Buka (NO REVIEWS) 2014/11/05 19:14:50 it's would be ENABLE_PRINTING = (ENABLE_PRINT_PREV
}],
- ['enable_printing==2', {
- 'defines': ['ENABLE_PRINTING=1'],
+ ['enable_printing==1', {
+ 'defines': ['ENABLE_PRINT_PREVIEW=1'],
}],
['enable_spellcheck==1', {
'defines': ['ENABLE_SPELLCHECK=1'],
« no previous file with comments | « athena/extensions/chrome/athena_chrome_app_delegate.cc ('k') | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698