Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 701663002: Remove HTMLVideoElement. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan, abarth-chromium
CC:
ojan, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove HTMLVideoElement. This also removes some compositor related code, but there's not much of it anyway so we can just add it back later when we do <iframe>. R=ojan@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3c577b6f465a01b2e9f16a3634242d99ba289f43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -934 lines) Patch
M sky/engine/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/core.gni View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/frame/ImageBitmap.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/ImageBitmap.cpp View 3 chunks +0 lines, -34 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/frame/UseCounter.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M sky/engine/core/html/HTMLImageLoader.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/html/HTMLMediaElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/html/HTMLMediaElement.cpp View 4 chunks +1 line, -9 lines 0 comments Download
M sky/engine/core/html/HTMLMediaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLTagNames.in View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/html/HTMLVideoElement.h View 1 chunk +0 lines, -102 lines 0 comments Download
D sky/engine/core/html/HTMLVideoElement.cpp View 1 chunk +0 lines, -238 lines 0 comments Download
D sky/engine/core/html/HTMLVideoElement.idl View 1 chunk +0 lines, -34 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.cpp View 2 chunks +13 lines, -33 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.idl View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContextBase.h View 6 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContextBase.cpp View 4 chunks +0 lines, -61 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContextBase.idl View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/loader/ImageLoader.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
D sky/engine/core/rendering/RenderVideo.h View 1 chunk +0 lines, -83 lines 0 comments Download
D sky/engine/core/rendering/RenderVideo.cpp View 1 chunk +0 lines, -231 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +1 line, -25 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ojan
In the future world, how will you do image processing of a video the way ...
6 years, 1 month ago (2014-11-03 23:53:05 UTC) #2
esprehn
On 2014/11/03 at 23:53:05, ojan wrote: > In the future world, how will you do ...
6 years, 1 month ago (2014-11-04 00:53:29 UTC) #3
abarth-chromium
On 2014/11/04 at 00:53:29, esprehn wrote: > On 2014/11/03 at 23:53:05, ojan wrote: > > ...
6 years, 1 month ago (2014-11-04 01:05:35 UTC) #4
ojan
lgtm
6 years, 1 month ago (2014-11-04 02:01:52 UTC) #5
esprehn
6 years, 1 month ago (2014-11-04 02:02:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c577b6f465a01b2e9f16a3634242d99ba289f43.

Powered by Google App Engine
This is Rietveld 408576698