Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: sky/engine/core/html/HTMLMediaElement.cpp

Issue 701663002: Remove HTMLVideoElement. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/html/HTMLMediaElement.h ('k') | sky/engine/core/html/HTMLMediaElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLMediaElement.cpp
diff --git a/sky/engine/core/html/HTMLMediaElement.cpp b/sky/engine/core/html/HTMLMediaElement.cpp
index 5205593c0741aca988b24cc20675b801c83c3cf9..205e7fe1d35dc27c8f8f27fd5f94641ae4781f2d 100644
--- a/sky/engine/core/html/HTMLMediaElement.cpp
+++ b/sky/engine/core/html/HTMLMediaElement.cpp
@@ -44,7 +44,6 @@
#include "core/html/MediaError.h"
#include "core/html/MediaFragmentURIParser.h"
#include "core/html/TimeRanges.h"
-#include "core/rendering/RenderVideo.h"
#include "core/rendering/RenderView.h"
#include "core/rendering/compositing/RenderLayerCompositor.h"
#include "platform/ContentType.h"
@@ -400,7 +399,7 @@ bool HTMLMediaElement::rendererIsNeeded(const RenderStyle& style)
RenderObject* HTMLMediaElement::createRenderer(RenderStyle*)
{
- return new RenderMedia(this);
+ return 0;
}
Node::InsertionNotificationRequest HTMLMediaElement::insertedInto(ContainerNode* insertionPoint)
@@ -1162,9 +1161,6 @@ void HTMLMediaElement::setReadyState(ReadyState state)
m_duration = duration();
scheduleEvent(EventTypeNames::durationchange);
-
- if (isHTMLVideoElement())
- scheduleEvent(EventTypeNames::resize);
scheduleEvent(EventTypeNames::loadedmetadata);
if (renderer())
renderer()->updateFromElement();
@@ -2033,10 +2029,6 @@ void HTMLMediaElement::mediaPlayerSizeChanged()
{
WTF_LOG(Media, "HTMLMediaElement::mediaPlayerSizeChanged");
- ASSERT(hasVideo()); // "resize" makes no sense absent video.
- if (m_readyState > HAVE_NOTHING && isHTMLVideoElement())
- scheduleEvent(EventTypeNames::resize);
-
if (renderer())
renderer()->updateFromElement();
}
« no previous file with comments | « sky/engine/core/html/HTMLMediaElement.h ('k') | sky/engine/core/html/HTMLMediaElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698