Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 700743002: Remove margin collapsing. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, rafaelw
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove margin collapsing. Margin collapsing is a document-oriented feature. For applications it just causes confusion and slowness. margins.sky has failure output because offsetTop is returning the wrong values. That's not new with this patch though. When I look at it visually in skydb, everything seems to be in the right place. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cc308be13b0c58a6f7fa39c879b8a067aaadc508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -828 lines) Patch
M sky/engine/core/rendering/RenderBlock.h View 3 chunks +2 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 7 chunks +11 lines, -70 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.h View 4 chunks +2 lines, -113 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 8 chunks +10 lines, -619 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M sky/tests/layout/margins.sky View 1 chunk +9 lines, -3 lines 0 comments Download
A sky/tests/layout/margins-absolute.sky View 1 chunk +21 lines, -0 lines 0 comments Download
A + sky/tests/layout/margins-absolute-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/tests/layout/margins-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-11-04 04:55:41 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-11-04 04:59:30 UTC) #3
ojan
6 years, 1 month ago (2014-11-04 05:30:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc308be13b0c58a6f7fa39c879b8a067aaadc508 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698