Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: sky/tests/layout/margins.sky

Issue 700743002: Remove margin collapsing. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/tests/layout/margins-absolute.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/layout/margins.sky
diff --git a/sky/tests/layout/margins.sky b/sky/tests/layout/margins.sky
index 7ff923694722ca9fcf3989ff8f28e00db97e097a..f720072e738f6d2c090794fefdb6c4be2bcd9f29 100644
--- a/sky/tests/layout/margins.sky
+++ b/sky/tests/layout/margins.sky
@@ -1,17 +1,23 @@
<sky>
<import src="../resources/check-layout.sky" as="checkLayout" />
<style>
+ .root {
+ margin: 5px;
+ }
.child {
margin: 10px;
height: 30px;
}
</style>
- <div class="root" data-expected-height="70" data-total-y="10" style="background-color: pink">
- <div class="child" data-total-y="10" style="background-color: salmon"></div>
- <div class="child" data-total-y="50" style="background-color: papayawhip"></div>
+ <div class="root" data-expected-height="100" data-total-y="5" style="background-color: pink">
+ <!-- TODO(ojan): These numbers are right, but the test fails because we appear to have
+ broken offsetTop to not include the parent's margin-top. -->
+ <div class="child" data-total-y="15" style="background-color: salmon"></div>
+ <div class="child" data-total-y="65" style="background-color: papayawhip"></div>
</div>
<script>
checkLayout('.root');
</script>
</sky>
+
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/tests/layout/margins-absolute.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698