Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 697773002: Remove Element#attributes. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove Element#attributes. We now implement getAttributes() such that it returns a new set of Attr isntances on every call as well. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2c151432819d87f9526e25180a5179b27d67bdfd

Patch Set 1 #

Patch Set 2 : fix template binding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -606 lines) Patch
M sky/engine/bindings/core/v8/V8GCController.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/V8NodeCustom.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/core.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Attr.h View 1 chunk +9 lines, -28 lines 0 comments Download
M sky/engine/core/dom/Attr.cpp View 2 chunks +5 lines, -41 lines 0 comments Download
M sky/engine/core/dom/Attr.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 5 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/dom/Element.h View 5 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 11 chunks +1 line, -114 lines 0 comments Download
M sky/engine/core/dom/Element.idl View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/core/dom/ElementRareData.h View 4 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/dom/ElementRareData.cpp View 2 chunks +1 line, -12 lines 0 comments Download
D sky/engine/core/dom/NamedNodeMap.h View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/engine/core/dom/NamedNodeMap.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/engine/core/dom/NamedNodeMap.idl View 1 chunk +0 lines, -29 lines 0 comments Download
M sky/engine/core/dom/Node.h View 5 chunks +3 lines, -10 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 13 chunks +2 lines, -55 lines 0 comments Download
M sky/engine/core/dom/Range.cpp View 7 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/dom/TreeScopeAdopter.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/editing/MarkupAccumulator.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/public/web/WebNode.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/framework/inspector/dom-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/sky-element/TemplateBinding.sky View 1 1 chunk +3 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/attribute-collection.sky View 2 chunks +29 lines, -33 lines 0 comments Download
M sky/tests/lowlevel/attribute-collection-expected.txt View 1 chunk +6 lines, -8 lines 0 comments Download
M sky/tests/mutation-observer/observe-attributes.sky View 1 chunk +0 lines, -32 lines 0 comments Download
M sky/tests/mutation-observer/observe-attributes-expected.txt View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
LGTM Please fix any uses for this API in the framework.
6 years, 1 month ago (2014-10-31 22:08:00 UTC) #1
esprehn
6 years, 1 month ago (2014-10-31 22:10:58 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2c151432819d87f9526e25180a5179b27d67bdfd.

Powered by Google App Engine
This is Rietveld 408576698