Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: sky/engine/core/dom/Node.h

Issue 697773002: Remove Element#attributes. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix template binding. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/NamedNodeMap.idl ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Node.h
diff --git a/sky/engine/core/dom/Node.h b/sky/engine/core/dom/Node.h
index 8f3a04ebb9555d6f647e52cd86d93d15f7853254..cd948d00a0746d30cb90c256876c3f06bd3bff1b 100644
--- a/sky/engine/core/dom/Node.h
+++ b/sky/engine/core/dom/Node.h
@@ -59,7 +59,6 @@ class HTMLQualifiedName;
class IntRect;
class KeyboardEvent;
class NSResolver;
-class NamedNodeMap;
class NodeEventContext;
class NodeList;
class NodeRareData;
@@ -120,7 +119,6 @@ class Node : NODE_BASE_CLASSES {
public:
enum NodeType {
ELEMENT_NODE = 1,
- ATTRIBUTE_NODE = 2,
TEXT_NODE = 3,
DOCUMENT_NODE = 9,
DOCUMENT_FRAGMENT_NODE = 11,
@@ -204,7 +202,6 @@ public:
}
void setCustomElementState(CustomElementState newState);
- virtual bool isAttributeNode() const { return false; }
virtual bool isCharacterDataNode() const { return false; }
// StyledElements allow inline style (style="border: 1px"), presentational attributes (ex. color),
@@ -225,9 +222,6 @@ public:
bool hasCustomStyleCallbacks() const { return getFlag(HasCustomStyleCallbacksFlag); }
- bool hasSyntheticAttrChildNodes() const { return getFlag(HasSyntheticAttrChildNodesFlag); }
- void setHasSyntheticAttrChildNodes(bool flag) { setFlag(flag, HasSyntheticAttrChildNodesFlag); }
-
// If this node is in a shadow tree, returns its shadow host. Otherwise, returns 0.
Element* shadowHost() const;
ShadowRoot* containingShadowRoot() const;
@@ -631,14 +625,13 @@ private:
IsEditingTextFlag = 1 << 23,
HasWeakReferencesFlag = 1 << 24,
V8CollectableDuringMinorGCFlag = 1 << 25,
- HasSyntheticAttrChildNodesFlag = 1 << 26,
- HasEventTargetDataFlag = 1 << 27,
- AlreadySpellCheckedFlag = 1 << 28,
+ HasEventTargetDataFlag = 1 << 26,
+ AlreadySpellCheckedFlag = 1 << 27,
DefaultNodeFlags = IsFinishedParsingChildrenFlag | ChildNeedsStyleRecalcFlag | NeedsReattachStyleChange
};
- // 4 bits remaining.
+ // 5 bits remaining.
bool getFlag(NodeFlags mask) const { return m_nodeFlags & mask; }
void setFlag(bool f, NodeFlags mask) { m_nodeFlags = (m_nodeFlags & ~mask) | (-(int32_t)f & mask); }
« no previous file with comments | « sky/engine/core/dom/NamedNodeMap.idl ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698