Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: sky/engine/core/dom/Attr.h

Issue 697773002: Remove Element#attributes. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix template binding. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/core.gni ('k') | sky/engine/core/dom/Attr.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
11 * version 2 of the License, or (at your option) any later version. 11 * version 2 of the License, or (at your option) any later version.
12 * 12 *
13 * This library is distributed in the hope that it will be useful, 13 * This library is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 * Library General Public License for more details. 16 * Library General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU Library General Public License 18 * You should have received a copy of the GNU Library General Public License
19 * along with this library; see the file COPYING.LIB. If not, write to 19 * along with this library; see the file COPYING.LIB. If not, write to
20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
21 * Boston, MA 02110-1301, USA. 21 * Boston, MA 02110-1301, USA.
22 * 22 *
23 */ 23 */
24 24
25 #ifndef Attr_h 25 #ifndef Attr_h
26 #define Attr_h 26 #define Attr_h
27 27
28 #include "core/dom/Node.h" 28 #include "bindings/core/v8/ScriptWrappable.h"
29 #include "core/dom/QualifiedName.h" 29 #include "core/dom/QualifiedName.h"
30 #include "wtf/RefCounted.h"
31 #include "wtf/text/AtomicString.h"
30 32
31 namespace blink { 33 namespace blink {
32 34
33 class Attr final : public Node { 35 class Attr : public RefCounted<Attr>, public ScriptWrappable {
34 DEFINE_WRAPPERTYPEINFO(); 36 DEFINE_WRAPPERTYPEINFO();
35 public: 37 public:
36 static PassRefPtr<Attr> create(Element&, const QualifiedName&); 38 static PassRefPtr<Attr> create(const QualifiedName& name, const AtomicString & value);
37 virtual ~Attr(); 39 ~Attr();
38 40
39 String name() const { return m_name.localName(); } 41 String name() const { return m_name.localName(); }
40 Element* ownerElement() const { return m_element; } 42 const AtomicString& value() const { return m_value; }
41
42 const AtomicString& value() const;
43 void setValue(const AtomicString&);
44
45 void detachFromElement();
46
47 // FIXME(sky): Remove this.
48 virtual const AtomicString& localName() const override { return m_name.local Name(); }
49
50 virtual void trace(Visitor*) override;
51 43
52 private: 44 private:
53 Attr(Element&, const QualifiedName&); 45 Attr(const QualifiedName& name, const AtomicString& value);
54 46
55 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check.
56
57 virtual String nodeName() const override { return name(); }
58 virtual NodeType nodeType() const override { return ATTRIBUTE_NODE; }
59
60 virtual PassRefPtr<Node> cloneNode(bool deep = true) override { return nullp tr; }
61
62 virtual bool isAttributeNode() const override { return true; }
63
64 RawPtr<Element> m_element;
65 QualifiedName m_name; 47 QualifiedName m_name;
48 AtomicString m_value;
66 }; 49 };
67 50
68 DEFINE_NODE_TYPE_CASTS(Attr, isAttributeNode());
69
70 } // namespace blink 51 } // namespace blink
71 52
72 #endif // Attr_h 53 #endif // Attr_h
OLDNEW
« no previous file with comments | « sky/engine/core/core.gni ('k') | sky/engine/core/dom/Attr.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698