sky/engine/bindings/core/v8/custom/V8NodeCustom.cpp - Issue 697773002: Remove Element#attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/custom/V8NodeCustom.cpp

Issue 697773002: Remove Element#attributes. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix template binding. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/custom/V8NodeCustom.cpp

diff --git a/sky/engine/bindings/core/v8/custom/V8NodeCustom.cpp b/sky/engine/bindings/core/v8/custom/V8NodeCustom.cpp

index de5707833c93542e010ce7fadccbd89ed846a47f..b9b6245f4533b4c3aeb0b304c8d565114b556a52 100644

--- a/sky/engine/bindings/core/v8/custom/V8NodeCustom.cpp

+++ b/sky/engine/bindings/core/v8/custom/V8NodeCustom.cpp

@@ -60,8 +60,6 @@ v8::Handle<v8::Object> wrap(Node* impl, v8::Handle<v8::Object> creationContext,

if (impl->isHTMLElement())

return wrap(toHTMLElement(impl), creationContext, isolate);

return V8Element::createWrapper(toElement(impl), creationContext, isolate);

- case Node::ATTRIBUTE_NODE:

- return wrap(toAttr(impl), creationContext, isolate);

case Node::TEXT_NODE:

return wrap(toText(impl), creationContext, isolate);

case Node::DOCUMENT_NODE:

« no previous file with comments | « sky/engine/bindings/core/v8/V8GCController.cpp ('k') | sky/engine/core/core.gni » ('j') | no next file with comments »