Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 697023002: Cancel uninstall if the uninstall dialog's parent window is destroyed (Closed)

Created:
6 years, 1 month ago by pkotwicz
Modified:
6 years, 1 month ago
Reviewers:
Finnur, Nico, Andre
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cancel uninstall if the uninstall dialog's parent window is destroyed prior to the uninstall dialog showing. BUG=424999, 397396 TEST=ExtensionUninstallDialogViewBrowserTest.TrackParentWindowDestruction Committed: https://crrev.com/ea87b86d5bd1abe26636abfc19af28e755da7585 Cr-Commit-Position: refs/heads/master@{#302691}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -19 lines) Patch
M chrome/browser/extensions/extension_uninstall_dialog.h View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm View 1 2 3 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 5 chunks +19 lines, -4 lines 0 comments Download
A chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc View 1 1 chunk +76 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (11 generated)
pkotwicz
finnur@ PTAL
6 years, 1 month ago (2014-11-02 01:29:12 UTC) #5
Finnur
LGTM https://codereview.chromium.org/697023002/diff/40001/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc File chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc (right): https://codereview.chromium.org/697023002/diff/40001/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc#newcode34 chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc:34: bool DidCancel() { return canceled_; } nit: did_cancel() ...
6 years, 1 month ago (2014-11-02 21:38:25 UTC) #6
pkotwicz
thakis@ for chrome/browser/ui/cocoa OWNERS
6 years, 1 month ago (2014-11-03 16:13:51 UTC) #8
Nico
i don't think this will build https://codereview.chromium.org/697023002/diff/60001/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm File chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm (right): https://codereview.chromium.org/697023002/diff/60001/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm#newcode41 chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm:41: : extensions::ExtensionUninstallDialog(profile, parent, ...
6 years, 1 month ago (2014-11-03 17:51:26 UTC) #9
pkotwicz
Thanks for noticing. thakis@ can you please take another look?
6 years, 1 month ago (2014-11-04 01:43:48 UTC) #10
Nico
cocoa lgtm, but one remark: https://codereview.chromium.org/697023002/diff/80001/chrome/browser/extensions/extension_uninstall_dialog.h File chrome/browser/extensions/extension_uninstall_dialog.h (right): https://codereview.chromium.org/697023002/diff/80001/chrome/browser/extensions/extension_uninstall_dialog.h#newcode46 chrome/browser/extensions/extension_uninstall_dialog.h:46: gfx::NativeWindow parent, Shouldn't this ...
6 years, 1 month ago (2014-11-04 02:20:38 UTC) #11
pkotwicz
https://codereview.chromium.org/697023002/diff/80001/chrome/browser/extensions/extension_uninstall_dialog.h File chrome/browser/extensions/extension_uninstall_dialog.h (right): https://codereview.chromium.org/697023002/diff/80001/chrome/browser/extensions/extension_uninstall_dialog.h#newcode46 chrome/browser/extensions/extension_uninstall_dialog.h:46: gfx::NativeWindow parent, We use the parameter in the views ...
6 years, 1 month ago (2014-11-04 15:08:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697023002/80001
6 years, 1 month ago (2014-11-04 15:09:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/2537)
6 years, 1 month ago (2014-11-04 15:27:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697023002/100001
6 years, 1 month ago (2014-11-04 18:43:56 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8423)
6 years, 1 month ago (2014-11-04 20:00:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697023002/100001
6 years, 1 month ago (2014-11-04 21:23:40 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:100001)
6 years, 1 month ago (2014-11-04 22:42:53 UTC) #23
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/ea87b86d5bd1abe26636abfc19af28e755da7585 Cr-Commit-Position: refs/heads/master@{#302691}
6 years, 1 month ago (2014-11-04 22:43:32 UTC) #24
Andre
This change won't compile on MacViews (Mac with toolkit_views=1), becase MacViews does not use Aura. ...
6 years, 1 month ago (2014-11-12 00:49:56 UTC) #26
pkotwicz
6 years, 1 month ago (2014-11-12 02:32:42 UTC) #27
Message was sent while issue was closed.
extension_uninstall_dialog_view is part of
chrome_browser_ui_views_non_mac_sources. Unless the file got moved out of that
list recently.
Regardless, the right place to discuss this is as part of a crbug.

Yes, using NativeWindowTracker would be an ok alternative.

Powered by Google App Engine
This is Rietveld 408576698