chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm - Issue 697023002: Cancel uninstall if the uninstall dialog's parent window is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

Issue 697023002: Cancel uninstall if the uninstall dialog's parent window is destroyed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_uninstall_dialog.cc ('k') | chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm b/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

index b050d84705c007bf801621285e8d6bca8522d65c..436fedff972befe6c1b9ac4725fcdea9cd60f6f9 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

@@ -25,9 +25,7 @@ namespace {

class ExtensionUninstallDialogCocoa

: public extensions::ExtensionUninstallDialog {

public:

- ExtensionUninstallDialogCocoa(Profile* profile,

- gfx::NativeWindow parent,

- Delegate* delegate);

+ ExtensionUninstallDialogCocoa(Profile* profile, Delegate* delegate);

~ExtensionUninstallDialogCocoa() override;

private:

@@ -36,9 +34,8 @@ class ExtensionUninstallDialogCocoa

ExtensionUninstallDialogCocoa::ExtensionUninstallDialogCocoa(

Profile* profile,

- gfx::NativeWindow parent,

extensions::ExtensionUninstallDialog::Delegate* delegate)

- : extensions::ExtensionUninstallDialog(profile, parent, delegate) {

+ : extensions::ExtensionUninstallDialog(profile, delegate) {

}

ExtensionUninstallDialogCocoa::~ExtensionUninstallDialogCocoa() {}

@@ -73,5 +70,5 @@ extensions::ExtensionUninstallDialog*

extensions::ExtensionUninstallDialog::Create(Profile* profile,

gfx::NativeWindow parent,

Delegate* delegate) {

- return new ExtensionUninstallDialogCocoa(profile, parent, delegate);

+ return new ExtensionUninstallDialogCocoa(profile, delegate);

}