Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4341)

Unified Diff: chrome/browser/extensions/extension_uninstall_dialog.h

Issue 697023002: Cancel uninstall if the uninstall dialog's parent window is destroyed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_uninstall_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_uninstall_dialog.h
diff --git a/chrome/browser/extensions/extension_uninstall_dialog.h b/chrome/browser/extensions/extension_uninstall_dialog.h
index 33e6c3b1069f2a3521039ff4032acd090fb093bc..85e9811e17704d8f0cea3e95bfcab3a0b7434248 100644
--- a/chrome/browser/extensions/extension_uninstall_dialog.h
+++ b/chrome/browser/extensions/extension_uninstall_dialog.h
@@ -63,17 +63,11 @@ class ExtensionUninstallDialog
protected:
// Constructor used by the derived classes.
- ExtensionUninstallDialog(Profile* profile,
- gfx::NativeWindow parent,
- Delegate* delegate);
+ ExtensionUninstallDialog(Profile* profile, Delegate* delegate);
// TODO(sashab): Remove protected members: crbug.com/397395
Profile* const profile_;
- // TODO(sashab): Investigate lifetime issue of this window variable:
- // crbug.com/397396
- gfx::NativeWindow parent_;
-
// The delegate we will call Accepted/Canceled on after confirmation dialog.
Delegate* delegate_;
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_uninstall_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698