Rename and clarify semantics of GrContext::resolveRenderTarget.

Rename and clarify semantics of GrContext::resolveRenderTarget.

Committed: https://skia.googlesource.com/skia/+/87a94eb1632d06eeeb89490a91565e786440d6d0

[bsalomon, 2014-11-03 21:43:49]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, joshualitt@google.com

[joshualitt, 2014-11-03 21:47:45]

https://codereview.chromium.org/696293004/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/696293004/diff/1/src/gpu/GrContext.cpp#newcod...
src/gpu/GrContext.cpp:1539: ASSERT_OWNED_RESOURCE(surface);
The original code had a check for needing resolve, is that no longer necessary?

https://codereview.chromium.org/696293004/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/696293004/diff/1/src/gpu/SkGpuDevice.cpp#newc...
src/gpu/SkGpuDevice.cpp:1750: fRenderTarget->prepareForExternalRead();
I thought we had to flush here?

[bsalomon, 2014-11-03 21:54:16]

https://codereview.chromium.org/696293004/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/696293004/diff/1/src/gpu/GrContext.cpp#newcod...
src/gpu/GrContext.cpp:1539: ASSERT_OWNED_RESOURCE(surface);
On 2014/11/03 21:47:45, joshualitt wrote:
> The original code had a check for needing resolve, is that no longer
necessary?

I did that to try to avoid the flush if the surface wasn't MSAA. But now the
semantics requie the flush so no reason to check it.

https://codereview.chromium.org/696293004/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/696293004/diff/1/src/gpu/SkGpuDevice.cpp#newc...
src/gpu/SkGpuDevice.cpp:1750: fRenderTarget->prepareForExternalRead();
On 2014/11/03 21:47:45, joshualitt wrote:
> I thought we had to flush here?

The new semantics of prepareForExternalRead() mean that it will do the flush if
necessary.

[joshualitt, 2014-11-03 21:58:09]

On 2014/11/03 21:54:16, bsalomon wrote:
> https://codereview.chromium.org/696293004/diff/1/src/gpu/GrContext.cpp
> File src/gpu/GrContext.cpp (right):
> 
>
https://codereview.chromium.org/696293004/diff/1/src/gpu/GrContext.cpp#newcod...
> src/gpu/GrContext.cpp:1539: ASSERT_OWNED_RESOURCE(surface);
> On 2014/11/03 21:47:45, joshualitt wrote:
> > The original code had a check for needing resolve, is that no longer
> necessary?
> 
> I did that to try to avoid the flush if the surface wasn't MSAA. But now the
> semantics requie the flush so no reason to check it.
> 
> https://codereview.chromium.org/696293004/diff/1/src/gpu/SkGpuDevice.cpp
> File src/gpu/SkGpuDevice.cpp (right):
> 
>
https://codereview.chromium.org/696293004/diff/1/src/gpu/SkGpuDevice.cpp#newc...
> src/gpu/SkGpuDevice.cpp:1750: fRenderTarget->prepareForExternalRead();
> On 2014/11/03 21:47:45, joshualitt wrote:
> > I thought we had to flush here?
> 
> The new semantics of prepareForExternalRead() mean that it will do the flush
if
> necessary.

lgtm

[bsalomon, 2014-11-03 21:59:10]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-11-03 22:00:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696293004/1

[commit-bot: I haz the power, 2014-11-03 22:28:42]

Committed patchset #1 (id:1) as 87a94eb1632d06eeeb89490a91565e786440d6d0