src/gpu/SkGpuDevice.cpp - Issue 696293004: Rename and clarify semantics of GrContext::resolveRenderTarget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/SkGpuDevice.cpp

Issue 696293004: Rename and clarify semantics of GrContext::resolveRenderTarget. (Closed) Base URL: https://skia.googlesource.com/skia.git@fix

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/SkGpuDevice.cpp

diff --git a/src/gpu/SkGpuDevice.cpp b/src/gpu/SkGpuDevice.cpp

index 075d4d8af49f337e32c6abc6fe1f855ee07ea673..da81c696d2aa5857ee5d6e5b3b878fa9bebc7ed5 100644

--- a/src/gpu/SkGpuDevice.cpp

+++ b/src/gpu/SkGpuDevice.cpp

@@ -1747,7 +1747,7 @@ bool SkGpuDevice::filterTextFlags(const SkPaint& paint, TextFlags* flags) {

void SkGpuDevice::flush() {

DO_DEFERRED_CLEAR();

- fContext->resolveRenderTarget(fRenderTarget);

+ fRenderTarget->prepareForExternalRead();

joshualitt 2014/11/03 21:47:45 I thought we had to flush here?

bsalomon 2014/11/03 21:54:16 The new semantics of prepareForExternalRead() mean

}

///////////////////////////////////////////////////////////////////////////////

« src/gpu/GrContext.cpp ('K') | « src/gpu/GrSurface.cpp ('k') | no next file » | no next file with comments »