Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 69533003: Upgrade parser-created Custom Elements in creation order. (Closed)

Created:
7 years, 1 month ago by dominicc (has gone to gerrit)
Modified:
7 years, 1 month ago
Reviewers:
dglazkov
CC:
blink-reviews, Nils Barth (inactive), sorvell, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Upgrade parser-created Custom Elements in creation order. Originally, parser-created Custom Elements were upgraded in reverse order (which quickly and dirtily ensured that an element's children were upgraded before the element itself.) Then we rethought this and upgraded them post-order (which meant an element's children were still upgraded before the element itself, but siblings were upgraded in order.) Now parser-created Custom Elements are upgraded in creation order (ie pre-order.) This is consistent with how Custom Elements are upgraded when cloning a subtree of nodes. This is described here: <https://www.w3.org/Bugs/Public/show_bug.cgi?id=23778>; BUG=234509 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162229

Patch Set 1 #

Patch Set 2 : Neater diff. #

Patch Set 3 : Bring patch to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -55 lines) Patch
M LayoutTests/fast/dom/custom/element-upgrade.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/element-upgrade-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-innerHTML.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-innerHTML-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 2 chunks +12 lines, -8 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M Source/core/dom/custom/CustomElement.cpp View 3 chunks +0 lines, -16 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.h View 1 chunk +2 lines, -8 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dominicc (has gone to gerrit)
PTAL
7 years, 1 month ago (2013-11-15 07:14:50 UTC) #1
dominicc (has gone to gerrit)
morrita is under the weather... +dglazkov, -morrita.
7 years, 1 month ago (2013-11-18 08:02:53 UTC) #2
dglazkov
lgtm
7 years, 1 month ago (2013-11-18 18:02:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/69533003/60001
7 years, 1 month ago (2013-11-18 18:02:32 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 20:24:54 UTC) #5
Message was sent while issue was closed.
Change committed as 162229

Powered by Google App Engine
This is Rietveld 408576698