Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: Source/core/dom/Node.cpp

Issue 69533003: Upgrade parser-created Custom Elements in creation order. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Bring patch to head. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/dom/custom/CustomElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index 59130835bd32f8038896112ec26dfcc804314a51..7462ba095b3b337f155b6c6f1b45a0471da86268 100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -2636,22 +2636,18 @@ void Node::setCustomElementState(CustomElementState newState)
ASSERT_NOT_REACHED(); // Everything starts in this state
return;
- case WaitingForParser:
- ASSERT(NotCustomElement == oldState);
- break;
-
case WaitingForUpgrade:
- ASSERT(NotCustomElement == oldState || WaitingForParser == oldState);
+ ASSERT(NotCustomElement == oldState);
break;
case Upgraded:
- ASSERT(WaitingForParser == oldState || WaitingForUpgrade == oldState);
+ ASSERT(WaitingForUpgrade == oldState);
break;
}
ASSERT(isHTMLElement() || isSVGElement());
- setFlag(newState & 1, CustomElementWaitingForParserOrIsUpgraded);
- setFlag(newState & 2, CustomElementWaitingForUpgradeOrIsUpgraded);
+ setFlag(CustomElement);
+ setFlag(newState == Upgraded, CustomElementUpgraded);
if (oldState == NotCustomElement || newState == Upgraded)
setNeedsStyleRecalc(); // :unresolved has changed
« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/dom/custom/CustomElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698