Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: Source/core/dom/custom/CustomElement.cpp

Issue 69533003: Upgrade parser-created Custom Elements in creation order. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Bring patch to head. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/dom/custom/CustomElementRegistrationContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/custom/CustomElement.cpp
diff --git a/Source/core/dom/custom/CustomElement.cpp b/Source/core/dom/custom/CustomElement.cpp
index 39dd59904a55d67cf53b429fa1b01bb8f8d12c3d..eea313cd8340b815bc6c77029916406bfa2c9059 100644
--- a/Source/core/dom/custom/CustomElement.cpp
+++ b/Source/core/dom/custom/CustomElement.cpp
@@ -99,10 +99,6 @@ void CustomElement::define(Element* element, PassRefPtr<CustomElementDefinition>
ASSERT_NOT_REACHED();
break;
- case Element::WaitingForParser:
- definitions().add(element, definition);
- break;
-
case Element::WaitingForUpgrade:
definitions().add(element, definition);
CustomElementCallbackScheduler::scheduleCreatedCallback(definition->callbacks(), element);
@@ -117,17 +113,6 @@ CustomElementDefinition* CustomElement::definitionFor(Element* element)
return definition;
}
-void CustomElement::didFinishParsingChildren(Element* element)
-{
- ASSERT(element->customElementState() == Element::WaitingForParser);
- element->setCustomElementState(Element::WaitingForUpgrade);
-
- CustomElementObserver::notifyElementDidFinishParsingChildren(element);
-
- if (CustomElementDefinition* definition = definitions().get(element))
- CustomElementCallbackScheduler::scheduleCreatedCallback(definition->callbacks(), element);
-}
-
void CustomElement::attributeDidChange(Element* element, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue)
{
ASSERT(element->customElementState() == Element::Upgraded);
@@ -157,7 +142,6 @@ void CustomElement::wasDestroyed(Element* element)
ASSERT_NOT_REACHED();
break;
- case Element::WaitingForParser:
case Element::WaitingForUpgrade:
case Element::Upgraded:
definitions().remove(element);
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/dom/custom/CustomElementRegistrationContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698