Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 694703002: Remove lots of dead virtuals from Element. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium, ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove lots of dead virtuals from Element. Mostly form related things we don't need now. R=ojan@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/186afdecedf377a7604602318ef7a0b79526a33b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -62 lines) Patch
M sky/engine/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Element.h View 3 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Node.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/events/EventDispatcher.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/MouseEvent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/public/web/WebElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/WebElement.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm
6 years, 1 month ago (2014-10-31 03:01:52 UTC) #2
esprehn
6 years, 1 month ago (2014-10-31 03:03:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
186afdecedf377a7604602318ef7a0b79526a33b.

Powered by Google App Engine
This is Rietveld 408576698