Issue 694703002: Remove lots of dead virtuals from Element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 694703002: Remove lots of dead virtuals from Element. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium, ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -62 lines)			Patch
M	sky/engine/core/dom/Document.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/dom/Element.h	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/dom/Node.cpp	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	sky/engine/core/events/EventDispatcher.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/events/MouseEvent.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayerScrollableArea.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	sky/engine/public/web/WebElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/web/WebElement.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

6 years, 1 month ago (2014-10-31 03:03:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
186afdecedf377a7604602318ef7a0b79526a33b.