Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: sky/engine/core/dom/Element.cpp

Issue 694703002: Remove lots of dead virtuals from Element. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1902 matching lines...) Expand 10 before | Expand all | Expand 10 after
1913 m_elementData = other.m_elementData->makeUniqueCopy(); 1913 m_elementData = other.m_elementData->makeUniqueCopy();
1914 1914
1915 AttributeCollection attributes = m_elementData->attributes(); 1915 AttributeCollection attributes = m_elementData->attributes();
1916 AttributeCollection::iterator end = attributes.end(); 1916 AttributeCollection::iterator end = attributes.end();
1917 for (AttributeCollection::iterator it = attributes.begin(); it != end; ++it) 1917 for (AttributeCollection::iterator it = attributes.begin(); it != end; ++it)
1918 attributeChangedFromParserOrByCloning(it->name(), it->value(), ModifiedB yCloning); 1918 attributeChangedFromParserOrByCloning(it->name(), it->value(), ModifiedB yCloning);
1919 } 1919 }
1920 1920
1921 void Element::cloneDataFromElement(const Element& other) 1921 void Element::cloneDataFromElement(const Element& other)
1922 { 1922 {
1923 // FIXME(sky): Merge these.
1923 cloneAttributesFromElement(other); 1924 cloneAttributesFromElement(other);
1924 copyNonAttributePropertiesFromElement(other);
1925 } 1925 }
1926 1926
1927 void Element::createUniqueElementData() 1927 void Element::createUniqueElementData()
1928 { 1928 {
1929 if (!m_elementData) 1929 if (!m_elementData)
1930 m_elementData = UniqueElementData::create(); 1930 m_elementData = UniqueElementData::create();
1931 else { 1931 else {
1932 ASSERT(!m_elementData->isUnique()); 1932 ASSERT(!m_elementData->isUnique());
1933 m_elementData = toShareableElementData(m_elementData)->makeUniqueCopy(); 1933 m_elementData = toShareableElementData(m_elementData)->makeUniqueCopy();
1934 } 1934 }
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
2103 { 2103 {
2104 #if ENABLE(OILPAN) 2104 #if ENABLE(OILPAN)
2105 if (hasRareData()) 2105 if (hasRareData())
2106 visitor->trace(elementRareData()); 2106 visitor->trace(elementRareData());
2107 visitor->trace(m_elementData); 2107 visitor->trace(m_elementData);
2108 #endif 2108 #endif
2109 ContainerNode::trace(visitor); 2109 ContainerNode::trace(visitor);
2110 } 2110 }
2111 2111
2112 } // namespace blink 2112 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698