sky/engine/core/dom/Element.cpp - Issue 694703002: Remove lots of dead virtuals from Element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/Element.cpp

Issue 694703002: Remove lots of dead virtuals from Element. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/Element.cpp

diff --git a/sky/engine/core/dom/Element.cpp b/sky/engine/core/dom/Element.cpp

index 731cb21387ff0f8ad43eed193cbafb8c826d3488..c861072fc35757f366119032af6007c3ed95ddf4 100644

--- a/sky/engine/core/dom/Element.cpp

+++ b/sky/engine/core/dom/Element.cpp

@@ -1920,8 +1920,8 @@ void Element::cloneAttributesFromElement(const Element& other)

void Element::cloneDataFromElement(const Element& other)

{

+ // FIXME(sky): Merge these.

cloneAttributesFromElement(other);

- copyNonAttributePropertiesFromElement(other);

}

void Element::createUniqueElementData()

« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »