Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: sky/engine/core/dom/Document.cpp

Issue 694703002: Remove lots of dead virtuals from Element. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/core/dom/Element.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 2852 matching lines...) Expand 10 before | Expand all | Expand 10 after
2863 // The oldActiveElement renderer is null, dropped on :active by setting display: none, 2863 // The oldActiveElement renderer is null, dropped on :active by setting display: none,
2864 // for instance. We still need to clear the ActiveChain as the mouse is released. 2864 // for instance. We still need to clear the ActiveChain as the mouse is released.
2865 for (Node* node = oldActiveElement; node; node = NodeRenderingTraversal: :parent(node)) { 2865 for (Node* node = oldActiveElement; node; node = NodeRenderingTraversal: :parent(node)) {
2866 ASSERT(!node->isTextNode()); 2866 ASSERT(!node->isTextNode());
2867 node->setActive(false); 2867 node->setActive(false);
2868 m_userActionElements.setInActiveChain(node, false); 2868 m_userActionElements.setInActiveChain(node, false);
2869 } 2869 }
2870 setActiveHoverElement(nullptr); 2870 setActiveHoverElement(nullptr);
2871 } else { 2871 } else {
2872 Element* newActiveElement = innerElementInDocument; 2872 Element* newActiveElement = innerElementInDocument;
2873 if (!oldActiveElement && newActiveElement && !newActiveElement->isDisabl edFormControl() && request.active() && !request.touchMove()) { 2873 if (!oldActiveElement && newActiveElement && request.active() && !reques t.touchMove()) {
2874 // We are setting the :active chain and freezing it. If future moves happen, they 2874 // We are setting the :active chain and freezing it. If future moves happen, they
2875 // will need to reference this chain. 2875 // will need to reference this chain.
2876 for (Node* node = newActiveElement; node; node = NodeRenderingTraver sal::parent(node)) { 2876 for (Node* node = newActiveElement; node; node = NodeRenderingTraver sal::parent(node)) {
2877 ASSERT(!node->isTextNode()); 2877 ASSERT(!node->isTextNode());
2878 m_userActionElements.setInActiveChain(node, true); 2878 m_userActionElements.setInActiveChain(node, true);
2879 } 2879 }
2880 setActiveHoverElement(newActiveElement); 2880 setActiveHoverElement(newActiveElement);
2881 } 2881 }
2882 } 2882 }
2883 // If the mouse has just been pressed, set :active on the chain. Those (and only those) 2883 // If the mouse has just been pressed, set :active on the chain. Those (and only those)
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
3129 using namespace blink; 3129 using namespace blink;
3130 void showLiveDocumentInstances() 3130 void showLiveDocumentInstances()
3131 { 3131 {
3132 WeakDocumentSet& set = liveDocumentSet(); 3132 WeakDocumentSet& set = liveDocumentSet();
3133 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 3133 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
3134 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) { 3134 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) {
3135 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data()); 3135 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data());
3136 } 3136 }
3137 } 3137 }
3138 #endif 3138 #endif
OLDNEW
« no previous file with comments | « no previous file | sky/engine/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698