Issue 691523002: Separate out GrSurfaceConfig's fields from other structs used to create GrGL* GrSurface subclasses

Issue 691523002: Separate out GrSurfaceConfig's fields from other structs used to create GrGL* GrSurface subclasses (Closed)

Created:
6 years, 1 month ago by bsalomon

Modified:
6 years, 1 month ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Separate out GrSurfaceConfig's fields from other structs used to create GrGL* subclasses of GrSurface. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/b15b4c1ce006319acf764a25ee4a6b73283654f8

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -251 lines)			Patch
M	src/gpu/gl/GrGLRenderTarget.h	View		2 chunks	+5 lines, -14 lines	0 comments	Download
M	src/gpu/gl/GrGLRenderTarget.cpp	View		1 chunk	+14 lines, -41 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.h	View		2 chunks	+4 lines, -9 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.cpp	View		1 chunk	+18 lines, -17 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 2	16 chunks	+129 lines, -165 lines	0 comments	Download

Total messages: 7 (2 generated)

bsalomon

The main goal here is that every GrGL subclass of GrSurface gets one GrSurfaceDesc that ...

6 years, 1 month ago (2014-10-29 14:11:32 UTC) #3

joshualitt

On 2014/10/29 14:11:32, bsalomon wrote: > The main goal here is that every GrGL subclass ...

6 years, 1 month ago (2014-10-29 15:21:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691523002/40001

6 years, 1 month ago (2014-10-29 15:23:20 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-10-29 19:42:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as b15b4c1ce006319acf764a25ee4a6b73283654f8