Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 689853003: Remove CSS Grid Layout and grid media queries. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove CSS Grid Layout and grid media queries. The two are unrelated, but it was easier to just grep for grid and remove them all. Aside from the media query change, there isn't any change in behavior since grid was behind a flag. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4504b4614d8c3038551c982ac3f6b335bf82577f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4536 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 2 chunks +0 lines, -34 lines 0 comments Download
M sky/engine/core/core.gni View 4 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 10 chunks +3 lines, -202 lines 0 comments Download
D sky/engine/core/css/CSSGridLineNamesValue.h View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/engine/core/css/CSSGridLineNamesValue.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
D sky/engine/core/css/CSSGridTemplateAreasValue.h View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/engine/core/css/CSSGridTemplateAreasValue.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 3 chunks +1 line, -18 lines 0 comments Download
M sky/engine/core/css/CSSValue.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/CSSValue.cpp View 6 chunks +0 lines, -28 lines 0 comments Download
M sky/engine/core/css/CSSValueKeywords.in View 4 chunks +1 line, -12 lines 0 comments Download
M sky/engine/core/css/MediaFeatureNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaQueryEvaluator.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/MediaQueryEvaluatorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaQueryExp.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/css/MediaQuerySetTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/StylePropertySerializer.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 4 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.h View 3 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 4 chunks +0 lines, -725 lines 0 comments Download
M sky/engine/core/css/resolver/StyleAdjuster.cpp View 6 chunks +7 lines, -14 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderConverter.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderConverter.cpp View 3 chunks +0 lines, -143 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 4 chunks +0 lines, -125 lines 0 comments Download
M sky/engine/core/frame/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 3 chunks +1 line, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 5 chunks +2 lines, -23 lines 0 comments Download
D sky/engine/core/rendering/RenderGrid.h View 1 chunk +0 lines, -159 lines 0 comments Download
D sky/engine/core/rendering/RenderGrid.cpp View 1 chunk +0 lines, -1397 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
D sky/engine/core/rendering/style/GridCoordinate.h View 1 chunk +0 lines, -187 lines 0 comments Download
D sky/engine/core/rendering/style/GridLength.h View 1 chunk +0 lines, -84 lines 0 comments Download
D sky/engine/core/rendering/style/GridPosition.h View 1 chunk +0 lines, -124 lines 0 comments Download
D sky/engine/core/rendering/style/GridResolvedPosition.h View 1 chunk +0 lines, -125 lines 0 comments Download
D sky/engine/core/rendering/style/GridResolvedPosition.cpp View 1 chunk +0 lines, -254 lines 0 comments Download
D sky/engine/core/rendering/style/GridTrackSize.h View 1 chunk +0 lines, -131 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 6 chunks +2 lines, -73 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 2 chunks +0 lines, -22 lines 0 comments Download
D sky/engine/core/rendering/style/StyleGridData.h View 1 chunk +0 lines, -86 lines 0 comments Download
D sky/engine/core/rendering/style/StyleGridData.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D sky/engine/core/rendering/style/StyleGridItemData.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/core/rendering/style/StyleGridItemData.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ojan
6 years, 1 month ago (2014-10-31 23:28:51 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-31 23:36:33 UTC) #3
ojan
Committed patchset #1 (id:1) manually as 4504b4614d8c3038551c982ac3f6b335bf82577f.
6 years, 1 month ago (2014-10-31 23:40:08 UTC) #4
eseidel
So flexbox is our only layout model?
6 years, 1 month ago (2014-10-31 23:57:55 UTC) #5
ojan
6 years, 1 month ago (2014-11-01 00:30:55 UTC) #6
Message was sent while issue was closed.
On 2014/10/31 at 23:57:55, eseidel wrote:
> So flexbox is our only layout model?

flex, inline and block for now. We'll add back some sort of grid-like thing in
the future, but not until we figure out how we want to do layout in general
(e.g. in JS or not).

Powered by Google App Engine
This is Rietveld 408576698