Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: sky/engine/core/css/resolver/StyleBuilderConverter.cpp

Issue 689853003: Remove CSS Grid Layout and grid media queries. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/sky/engine/core/css/resolver/StyleBuilderConverter.cpp b/sky/engine/core/css/resolver/StyleBuilderConverter.cpp
index 528679b0dea28eb1b0b2003e35db36b78e8a6df3..ff36f06e16ef270d0ada74e2f7c5ac9fb8215800 100644
--- a/sky/engine/core/css/resolver/StyleBuilderConverter.cpp
+++ b/sky/engine/core/css/resolver/StyleBuilderConverter.cpp
@@ -29,7 +29,6 @@
#include "core/css/CSSFontFeatureValue.h"
#include "core/css/CSSFunctionValue.h"
-#include "core/css/CSSGridLineNamesValue.h"
#include "core/css/CSSPrimitiveValueMappings.h"
#include "core/css/CSSShadowValue.h"
#include "core/css/Pair.h"
@@ -37,25 +36,6 @@
namespace blink {
-namespace {
-
-static GridLength convertGridTrackBreadth(const StyleResolverState& state, CSSPrimitiveValue* primitiveValue)
-{
- if (primitiveValue->getValueID() == CSSValueMinContent)
- return Length(MinContent);
-
- if (primitiveValue->getValueID() == CSSValueMaxContent)
- return Length(MaxContent);
-
- // Fractional unit.
- if (primitiveValue->isFlex())
- return GridLength(primitiveValue->getDoubleValue());
-
- return primitiveValue->convertToLength<FixedConversion | PercentConversion | AutoConversion>(state.cssToLengthConversionData());
-}
-
-} // namespace
-
Color StyleBuilderConverter::convertColor(StyleResolverState& state, CSSValue* value)
{
CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
@@ -151,129 +131,6 @@ FontDescription::VariantLigatures StyleBuilderConverter::convertFontVariantLigat
return FontDescription::VariantLigatures();
}
-GridPosition StyleBuilderConverter::convertGridPosition(StyleResolverState&, CSSValue* value)
-{
- // We accept the specification's grammar:
- // 'auto' | [ <integer> || <custom-ident> ] | [ span && [ <integer> || <custom-ident> ] ] | <custom-ident>
-
- GridPosition position;
-
- if (value->isPrimitiveValue()) {
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- // We translate <custom-ident> to <string> during parsing as it
- // makes handling it more simple.
- if (primitiveValue->isString()) {
- position.setNamedGridArea(primitiveValue->getStringValue());
- return position;
- }
-
- ASSERT(primitiveValue->getValueID() == CSSValueAuto);
- return position;
- }
-
- CSSValueList* values = toCSSValueList(value);
- ASSERT(values->length());
-
- bool isSpanPosition = false;
- // The specification makes the <integer> optional, in which case it default to '1'.
- int gridLineNumber = 1;
- String gridLineName;
-
- CSSValueListIterator it = values;
- CSSPrimitiveValue* currentValue = toCSSPrimitiveValue(it.value());
- if (currentValue->getValueID() == CSSValueSpan) {
- isSpanPosition = true;
- it.advance();
- currentValue = it.hasMore() ? toCSSPrimitiveValue(it.value()) : 0;
- }
-
- if (currentValue && currentValue->isNumber()) {
- gridLineNumber = currentValue->getIntValue();
- it.advance();
- currentValue = it.hasMore() ? toCSSPrimitiveValue(it.value()) : 0;
- }
-
- if (currentValue && currentValue->isString()) {
- gridLineName = currentValue->getStringValue();
- it.advance();
- }
-
- ASSERT(!it.hasMore());
- if (isSpanPosition)
- position.setSpanPosition(gridLineNumber, gridLineName);
- else
- position.setExplicitPosition(gridLineNumber, gridLineName);
-
- return position;
-}
-
-GridTrackSize StyleBuilderConverter::convertGridTrackSize(StyleResolverState& state, CSSValue* value)
-{
- if (value->isPrimitiveValue())
- return GridTrackSize(convertGridTrackBreadth(state, toCSSPrimitiveValue(value)));
-
- CSSFunctionValue* minmaxFunction = toCSSFunctionValue(value);
- CSSValueList* arguments = minmaxFunction->arguments();
- ASSERT_WITH_SECURITY_IMPLICATION(arguments->length() == 2);
- GridLength minTrackBreadth(convertGridTrackBreadth(state, toCSSPrimitiveValue(arguments->item(0))));
- GridLength maxTrackBreadth(convertGridTrackBreadth(state, toCSSPrimitiveValue(arguments->item(1))));
- return GridTrackSize(minTrackBreadth, maxTrackBreadth);
-}
-
-bool StyleBuilderConverter::convertGridTrackList(CSSValue* value, Vector<GridTrackSize>& trackSizes, NamedGridLinesMap& namedGridLines, OrderedNamedGridLines& orderedNamedGridLines, StyleResolverState& state)
-{
- // Handle 'none'.
- if (value->isPrimitiveValue()) {
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- return primitiveValue->getValueID() == CSSValueNone;
- }
-
- if (!value->isValueList())
- return false;
-
- size_t currentNamedGridLine = 0;
- for (CSSValueListIterator i = value; i.hasMore(); i.advance()) {
- CSSValue* currValue = i.value();
- if (currValue->isGridLineNamesValue()) {
- CSSGridLineNamesValue* lineNamesValue = toCSSGridLineNamesValue(currValue);
- for (CSSValueListIterator j = lineNamesValue; j.hasMore(); j.advance()) {
- String namedGridLine = toCSSPrimitiveValue(j.value())->getStringValue();
- NamedGridLinesMap::AddResult result = namedGridLines.add(namedGridLine, Vector<size_t>());
- result.storedValue->value.append(currentNamedGridLine);
- OrderedNamedGridLines::AddResult orderedInsertionResult = orderedNamedGridLines.add(currentNamedGridLine, Vector<String>());
- orderedInsertionResult.storedValue->value.append(namedGridLine);
- }
- continue;
- }
-
- ++currentNamedGridLine;
- trackSizes.append(convertGridTrackSize(state, currValue));
- }
-
- // The parser should have rejected any <track-list> without any <track-size> as
- // this is not conformant to the syntax.
- ASSERT(!trackSizes.isEmpty());
- return true;
-}
-
-void StyleBuilderConverter::createImplicitNamedGridLinesFromGridArea(const NamedGridAreaMap& namedGridAreas, NamedGridLinesMap& namedGridLines, GridTrackSizingDirection direction)
-{
- NamedGridAreaMap::const_iterator end = namedGridAreas.end();
- for (NamedGridAreaMap::const_iterator it = namedGridAreas.begin(); it != end; ++it) {
- GridSpan areaSpan = direction == ForRows ? it->value.rows : it->value.columns;
- {
- NamedGridLinesMap::AddResult startResult = namedGridLines.add(it->key + "-start", Vector<size_t>());
- startResult.storedValue->value.append(areaSpan.resolvedInitialPosition.toInt());
- std::sort(startResult.storedValue->value.begin(), startResult.storedValue->value.end());
- }
- {
- NamedGridLinesMap::AddResult endResult = namedGridLines.add(it->key + "-end", Vector<size_t>());
- endResult.storedValue->value.append(areaSpan.resolvedFinalPosition.toInt() + 1);
- std::sort(endResult.storedValue->value.begin(), endResult.storedValue->value.end());
- }
- }
-}
-
Length StyleBuilderConverter::convertLength(StyleResolverState& state, CSSValue* value)
{
CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
« no previous file with comments | « sky/engine/core/css/resolver/StyleBuilderConverter.h ('k') | sky/engine/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698