Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: sky/engine/core/css/resolver/MatchedPropertiesCache.cpp

Issue 689743002: First past at removing writing mode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 break; 133 break;
134 } 134 }
135 } 135 }
136 } 136 }
137 m_cache.removeAll(toRemove); 137 m_cache.removeAll(toRemove);
138 m_additionsSinceLastSweep = 0; 138 m_additionsSinceLastSweep = 0;
139 } 139 }
140 140
141 bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty le* style, const RenderStyle* parentStyle) 141 bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty le* style, const RenderStyle* parentStyle)
142 { 142 {
143 // FIXME: CSSPropertyWebkitWritingMode modifies state when applying to docum ent element. We can't skip the applying by caching.
144 if (element == element->document().documentElement() && element->document(). writingModeSetOnDocumentElement())
145 return false;
146 if (style->unique() || (style->styleType() != NOPSEUDO && parentStyle->uniqu e())) 143 if (style->unique() || (style->styleType() != NOPSEUDO && parentStyle->uniqu e()))
147 return false; 144 return false;
148 if (style->zoom() != RenderStyle::initialZoom()) 145 if (style->zoom() != RenderStyle::initialZoom())
149 return false; 146 return false;
150 if (style->writingMode() != RenderStyle::initialWritingMode()) 147 if (style->writingMode() != RenderStyle::initialWritingMode())
151 return false; 148 return false;
152 if (style->hasCurrentColor()) 149 if (style->hasCurrentColor())
153 return false; 150 return false;
154 // The cache assumes static knowledge about which properties are inherited. 151 // The cache assumes static knowledge about which properties are inherited.
155 if (parentStyle->hasExplicitlyInheritedProperties()) 152 if (parentStyle->hasExplicitlyInheritedProperties())
156 return false; 153 return false;
157 return true; 154 return true;
158 } 155 }
159 156
160 void MatchedPropertiesCache::trace(Visitor* visitor) 157 void MatchedPropertiesCache::trace(Visitor* visitor)
161 { 158 {
162 } 159 }
163 160
164 } 161 }
OLDNEW
« no previous file with comments | « sky/engine/core/css/resolver/FontBuilder.cpp ('k') | sky/engine/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698