Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: sky/engine/platform/LengthBox.cpp

Issue 689743002: First past at removing writing mode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.cpp ('k') | sky/engine/platform/geometry/LayoutBoxExtent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/LengthBox.cpp
diff --git a/sky/engine/platform/LengthBox.cpp b/sky/engine/platform/LengthBox.cpp
index 5afe9d2a0bced38f3d15d19de31b81009b38ba04..396fcc4cfb9ab5bdd0c82b519ad24e68368eabc9 100644
--- a/sky/engine/platform/LengthBox.cpp
+++ b/sky/engine/platform/LengthBox.cpp
@@ -45,33 +45,13 @@ const Length& LengthBox::logicalRight(WritingMode writingMode) const
const Length& LengthBox::before(WritingMode writingMode) const
{
- switch (writingMode) {
- case TopToBottomWritingMode:
- return m_top;
- case BottomToTopWritingMode:
- return m_bottom;
- case LeftToRightWritingMode:
- return m_left;
- case RightToLeftWritingMode:
- return m_right;
- }
- ASSERT_NOT_REACHED();
+ // FIXME(sky): Remove
return m_top;
}
const Length& LengthBox::after(WritingMode writingMode) const
{
- switch (writingMode) {
- case TopToBottomWritingMode:
- return m_bottom;
- case BottomToTopWritingMode:
- return m_top;
- case LeftToRightWritingMode:
- return m_right;
- case RightToLeftWritingMode:
- return m_left;
- }
- ASSERT_NOT_REACHED();
+ // FIXME(sky): Remove
return m_bottom;
}
« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.cpp ('k') | sky/engine/platform/geometry/LayoutBoxExtent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698