Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1853)

Unified Diff: sky/engine/core/rendering/style/RenderStyle.cpp

Issue 689743002: First past at removing writing mode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp ('k') | sky/engine/platform/LengthBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/style/RenderStyle.cpp
diff --git a/sky/engine/core/rendering/style/RenderStyle.cpp b/sky/engine/core/rendering/style/RenderStyle.cpp
index aae4ea9e07856404be1c62c12219df2ad38e2c07..355f6bf5df84b81275810657b0b8ac054ee5a1ff 100644
--- a/sky/engine/core/rendering/style/RenderStyle.cpp
+++ b/sky/engine/core/rendering/style/RenderStyle.cpp
@@ -1258,33 +1258,13 @@ Color RenderStyle::colorIncludingFallback(int colorProperty) const
const BorderValue& RenderStyle::borderBefore() const
{
- switch (writingMode()) {
- case TopToBottomWritingMode:
- return borderTop();
- case BottomToTopWritingMode:
- return borderBottom();
- case LeftToRightWritingMode:
- return borderLeft();
- case RightToLeftWritingMode:
- return borderRight();
- }
- ASSERT_NOT_REACHED();
+ // FIXME(sky): Remove
return borderTop();
}
const BorderValue& RenderStyle::borderAfter() const
{
- switch (writingMode()) {
- case TopToBottomWritingMode:
- return borderBottom();
- case BottomToTopWritingMode:
- return borderTop();
- case LeftToRightWritingMode:
- return borderRight();
- case RightToLeftWritingMode:
- return borderLeft();
- }
- ASSERT_NOT_REACHED();
+ // FIXME(sky): Remove
return borderBottom();
}
@@ -1304,33 +1284,13 @@ const BorderValue& RenderStyle::borderEnd() const
unsigned short RenderStyle::borderBeforeWidth() const
{
- switch (writingMode()) {
- case TopToBottomWritingMode:
- return borderTopWidth();
- case BottomToTopWritingMode:
- return borderBottomWidth();
- case LeftToRightWritingMode:
- return borderLeftWidth();
- case RightToLeftWritingMode:
- return borderRightWidth();
- }
- ASSERT_NOT_REACHED();
+ // FIXME(sky): Remove
return borderTopWidth();
}
unsigned short RenderStyle::borderAfterWidth() const
{
- switch (writingMode()) {
- case TopToBottomWritingMode:
- return borderBottomWidth();
- case BottomToTopWritingMode:
- return borderTopWidth();
- case LeftToRightWritingMode:
- return borderRightWidth();
- case RightToLeftWritingMode:
- return borderLeftWidth();
- }
- ASSERT_NOT_REACHED();
+ // FIXME(sky): Remove
return borderBottomWidth();
}
« no previous file with comments | « sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp ('k') | sky/engine/platform/LengthBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698