Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 689143002: Minor tweak to Session* to use base::Passed so ownership is clearer (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
CC:
chromium-reviews, marja+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Minor tweak to Session* to use base::Passed so ownership is clearer BUG=none TEST=none R=skuhne@chromium.org Committed: https://crrev.com/4883738595d0dde983244f921dd0d336312971f2 Cr-Commit-Position: refs/heads/master@{#302335}

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -26 lines) Patch
M chrome/browser/sessions/base_session_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sessions/session_backend.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/sessions/session_backend.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/sessions/session_backend_unittest.cc View 1 5 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sky
6 years, 1 month ago (2014-10-31 17:51:48 UTC) #1
Mr4D (OOO till 08-26)
lgtm
6 years, 1 month ago (2014-10-31 17:58:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689143002/1
6 years, 1 month ago (2014-10-31 18:00:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/1863) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/25084) win_chromium_rel_ng ...
6 years, 1 month ago (2014-10-31 18:24:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689143002/20001
6 years, 1 month ago (2014-10-31 20:32:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 22:12:06 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 22:12:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4883738595d0dde983244f921dd0d336312971f2
Cr-Commit-Position: refs/heads/master@{#302335}

Powered by Google App Engine
This is Rietveld 408576698