chrome/browser/sessions/base_session_service.cc - Issue 689143002: Minor tweak to Session* to use base::Passed so ownership is clearer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/base_session_service.cc

Issue 689143002: Minor tweak to Session* to use base::Passed so ownership is clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sessions/base_session_service.cc

diff --git a/chrome/browser/sessions/base_session_service.cc b/chrome/browser/sessions/base_session_service.cc

index fa988d355e797892fb3ef2f9f42595020b703cf9..2c6672d67b5c4f0b16b5d449852513a9fb7ec46e 100644

--- a/chrome/browser/sessions/base_session_service.cc

+++ b/chrome/browser/sessions/base_session_service.cc

@@ -91,12 +91,10 @@ void BaseSessionService::Save() {

if (pending_commands_.empty())

return;

- // We create a new ScopedVector which will receive all elements from the

- // current commands. This will also clear the current list.

RunTaskOnBackendThread(

FROM_HERE,

base::Bind(&SessionBackend::AppendCommands, backend(),

- new ScopedVector<SessionCommand>(pending_commands_.Pass()),

+ base::Passed(&pending_commands_),

pending_reset_));

if (pending_reset_) {

« no previous file with comments | « no previous file | chrome/browser/sessions/session_backend.h » ('j') | no next file with comments »