chrome/browser/sessions/session_backend.h - Issue 689143002: Minor tweak to Session* to use base::Passed so ownership is clearer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_backend.h

Issue 689143002: Minor tweak to Session* to use base::Passed so ownership is clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sessions/session_backend.h

diff --git a/chrome/browser/sessions/session_backend.h b/chrome/browser/sessions/session_backend.h

index e4fb4e13dbaef94ba2a2f95dc87f2d48bc0d625c..04263fa1aa61ed20e39df55110dae66cfcd8a01e 100644

--- a/chrome/browser/sessions/session_backend.h

+++ b/chrome/browser/sessions/session_backend.h

@@ -58,10 +58,7 @@ class SessionBackend : public base::RefCountedThreadSafe<SessionBackend> {

// Appends the specified commands to the current file. If reset_first is

// true the the current file is recreated.

- //

- // NOTE: this deletes SessionCommands in commands as well as the supplied

- // vector.

- void AppendCommands(ScopedVector<SessionCommand>* commands, bool reset_first);

+ void AppendCommands(ScopedVector<SessionCommand> commands, bool reset_first);

// Invoked from the service to read the commands that make up the last

// session, invokes ReadLastSessionCommandsImpl to do the work.

« no previous file with comments | « chrome/browser/sessions/base_session_service.cc ('k') | chrome/browser/sessions/session_backend.cc » ('j') | no next file with comments »