Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: chrome/browser/sessions/session_backend_unittest.cc

Issue 689143002: Minor tweak to Session* to use base::Passed so ownership is clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_backend.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_backend_unittest.cc
diff --git a/chrome/browser/sessions/session_backend_unittest.cc b/chrome/browser/sessions/session_backend_unittest.cc
index 4b0062fdbb2fd9575b9c228f8f505c28bf976a01..fafb195e5b195d277be67787a7664fbc55d0cacf 100644
--- a/chrome/browser/sessions/session_backend_unittest.cc
+++ b/chrome/browser/sessions/session_backend_unittest.cc
@@ -56,8 +56,7 @@ TEST_F(SessionBackendTest, SimpleReadWrite) {
struct TestData data = { 1, "a" };
SessionCommands commands;
commands.push_back(CreateCommandFromData(data));
- backend->AppendCommands(new ScopedVector<SessionCommand>(commands.Pass()),
- false);
+ backend->AppendCommands(commands.Pass(), false);
ASSERT_TRUE(commands.empty());
// Read it back in.
@@ -111,12 +110,10 @@ TEST_F(SessionBackendTest, RandomData) {
j != commands.end(); ++j) {
AssertCommandEqualsData(data[j - commands.begin()], *j);
}
- backend->AppendCommands(new ScopedVector<SessionCommand>(commands.Pass()),
- false);
+ backend->AppendCommands(commands.Pass(), false);
}
commands.push_back(CreateCommandFromData(data[i]));
- backend->AppendCommands(new ScopedVector<SessionCommand>(commands.Pass()),
- false);
+ backend->AppendCommands(commands.Pass(), false);
}
}
@@ -139,8 +136,7 @@ TEST_F(SessionBackendTest, BigData) {
reinterpret_cast<char*>(big_command->contents())[big_size - 1] = 'z';
commands.push_back(big_command);
commands.push_back(CreateCommandFromData(data[1]));
- backend->AppendCommands(new ScopedVector<SessionCommand>(commands.Pass()),
- false);
+ backend->AppendCommands(commands.Pass(), false);
backend = NULL;
backend = new SessionBackend(BaseSessionService::SESSION_RESTORE, path_);
@@ -163,9 +159,9 @@ TEST_F(SessionBackendTest, EmptyCommand) {
empty_command.command_id = 1;
scoped_refptr<SessionBackend> backend(
new SessionBackend(BaseSessionService::SESSION_RESTORE, path_));
- SessionCommands* empty_commands = new SessionCommands();
- empty_commands->push_back(CreateCommandFromData(empty_command));
- backend->AppendCommands(empty_commands, true);
+ SessionCommands empty_commands;
+ empty_commands.push_back(CreateCommandFromData(empty_command));
+ backend->AppendCommands(empty_commands.Pass(), true);
backend->MoveCurrentSessionToLastSession();
SessionCommands commands;
@@ -183,14 +179,12 @@ TEST_F(SessionBackendTest, Truncate) {
struct TestData first_data = { 1, "a" };
SessionCommands commands;
commands.push_back(CreateCommandFromData(first_data));
- backend->AppendCommands(new ScopedVector<SessionCommand>(commands.Pass()),
- false);
+ backend->AppendCommands(commands.Pass(), false);
// Write another command, this time resetting the file when appending.
struct TestData second_data = { 2, "b" };
commands.push_back(CreateCommandFromData(second_data));
- backend->AppendCommands(new ScopedVector<SessionCommand>(commands.Pass()),
- true);
+ backend->AppendCommands(commands.Pass(), true);
// Read it back in.
backend = NULL;
« no previous file with comments | « chrome/browser/sessions/session_backend.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698