Source/core/html/HTMLTitleElement.cpp - Issue 688933002: Make textContent trigger single DOMSubtreeModified event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTitleElement.cpp

Issue 688933002: Make textContent trigger single DOMSubtreeModified event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTitleElement.cpp

diff --git a/Source/core/html/HTMLTitleElement.cpp b/Source/core/html/HTMLTitleElement.cpp

index 659bdab424b9249983129e663bf485e088e67fc2..21e22f043ef6483f6d1e09f4043dadb839ec3a7c 100644

--- a/Source/core/html/HTMLTitleElement.cpp

+++ b/Source/core/html/HTMLTitleElement.cpp

@@ -85,7 +85,7 @@ void HTMLTitleElement::setText(const String &value)

// Avoid calling Document::setTitleElement() during intermediate steps.

m_ignoreTitleUpdatesWhenChildrenChange = !value.isEmpty();

- removeChildren();

+ removeChildren(OmitSubtreeModifiedEvent);

m_ignoreTitleUpdatesWhenChildrenChange = false;

if (!value.isEmpty())

« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »