Source/core/dom/Node.cpp - Issue 688933002: Make textContent trigger single DOMSubtreeModified event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 688933002: Make textContent trigger single DOMSubtreeModified event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index d14dfc63943404640a9af12e8b81ab5a7ad5a384..1b0a2d6997ec4c109f349592d6d6ee8cbef9c616 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -1401,11 +1401,14 @@ void Node::setTextContent(const String& text)

return;

ChildListMutationScope mutation(*this);

- container->removeChildren();

// Note: This API will not insert empty text nodes:

// http://dom.spec.whatwg.org/#dom-node-textcontent

- if (!text.isEmpty())

+ if (text.isEmpty()) {

+ container->removeChildren(DispatchSubtreeModifiedEvent);

+ } else {

+ container->removeChildren(OmitSubtreeModifiedEvent);

container->appendChild(document().createTextNode(text), ASSERT_NO_EXCEPTION);

+ }

return;

}

case DOCUMENT_NODE:

« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/html/HTMLTitleElement.cpp » ('j') | no next file with comments »