Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: Source/core/html/HTMLTitleElement.cpp

Issue 688933002: Make textContent trigger single DOMSubtreeModified event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 return result.toString(); 78 return result.toString();
79 } 79 }
80 80
81 void HTMLTitleElement::setText(const String &value) 81 void HTMLTitleElement::setText(const String &value)
82 { 82 {
83 RefPtrWillBeRawPtr<Node> protectFromMutationEvents(this); 83 RefPtrWillBeRawPtr<Node> protectFromMutationEvents(this);
84 ChildListMutationScope mutation(*this); 84 ChildListMutationScope mutation(*this);
85 85
86 // Avoid calling Document::setTitleElement() during intermediate steps. 86 // Avoid calling Document::setTitleElement() during intermediate steps.
87 m_ignoreTitleUpdatesWhenChildrenChange = !value.isEmpty(); 87 m_ignoreTitleUpdatesWhenChildrenChange = !value.isEmpty();
88 removeChildren(); 88 removeChildren(OmitSubtreeModifiedEvent);
89 m_ignoreTitleUpdatesWhenChildrenChange = false; 89 m_ignoreTitleUpdatesWhenChildrenChange = false;
90 90
91 if (!value.isEmpty()) 91 if (!value.isEmpty())
92 appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION); 92 appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION);
93 } 93 }
94 94
95 } 95 }
OLDNEW
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698