Source/core/svg/SVGUseElement.cpp - Issue 688933002: Make textContent trigger single DOMSubtreeModified event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGUseElement.cpp

Issue 688933002: Make textContent trigger single DOMSubtreeModified event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGUseElement.cpp

diff --git a/Source/core/svg/SVGUseElement.cpp b/Source/core/svg/SVGUseElement.cpp

index c1b0beaf5d413459994262e428e137e9677d19e4..ff18fc9196a64c347cfff697b72f899a4fca4bc3 100644

--- a/Source/core/svg/SVGUseElement.cpp

+++ b/Source/core/svg/SVGUseElement.cpp

@@ -297,7 +297,7 @@ void SVGUseElement::clearResourceReferences()

// FIXME: We should try to optimize this, to at least allow partial reclones.

if (ShadowRoot* shadowTreeRootElement = userAgentShadowRoot())

- shadowTreeRootElement->removeChildren();

+ shadowTreeRootElement->removeChildren(OmitSubtreeModifiedEvent);

m_needsShadowTreeRecreation = false;

document().unscheduleUseShadowTreeUpdate(*this);

« no previous file with comments | « Source/core/html/HTMLTitleElement.cpp ('k') | no next file » | no next file with comments »