Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 686633002: First pass at removing position:fixed. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

First pass at removing position:fixed. The root is never scrollable, so position:fixed doesn't do anything anymore. Also remove some dead frame-level scrolling code that interacted with fixed position things. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2fcbaa7d3056d1ac795339acc592404dd4484c79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -394 lines) Patch
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 2 chunks +3 lines, -77 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +2 lines, -38 lines 0 comments Download
M sky/engine/core/rendering/ClipRects.h View 7 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/LayoutState.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/PaintInvalidationState.cpp View 3 chunks +4 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 3 chunks +3 lines, -32 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 5 chunks +4 lines, -27 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderGeometryMap.h View 3 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderGeometryMap.cpp View 10 chunks +8 lines, -35 lines 0 comments Download
M sky/engine/core/rendering/RenderGeometryMapStep.h View 1 chunk +1 line, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 3 chunks +3 lines, -56 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.cpp View 3 chunks +1 line, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 3 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 3 chunks +2 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 chunk +1 line, -12 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-27 23:23:15 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-10-27 23:43:46 UTC) #3
ojan
6 years, 1 month ago (2014-10-28 02:42:51 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2fcbaa7d3056d1ac795339acc592404dd4484c79.

Powered by Google App Engine
This is Rietveld 408576698