Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: sky/engine/core/css/resolver/StyleAdjuster.cpp

Issue 686633002: First pass at removing position:fixed. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/css/CSSPrimitiveValueMappings.h ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 // cases where objects that should be blended as a single unit end up with a non-transparent 131 // cases where objects that should be blended as a single unit end up with a non-transparent
132 // object wedged in between them. Auto z-index also becomes 0 for objects th at specify transforms/masks/reflections. 132 // object wedged in between them. Auto z-index also becomes 0 for objects th at specify transforms/masks/reflections.
133 if (style->hasAutoZIndex() && ((element.document().documentElement() == elem ent) 133 if (style->hasAutoZIndex() && ((element.document().documentElement() == elem ent)
134 || style->hasOpacity() 134 || style->hasOpacity()
135 || style->hasTransformRelatedProperty() 135 || style->hasTransformRelatedProperty()
136 || style->hasMask() 136 || style->hasMask()
137 || style->clipPath() 137 || style->clipPath()
138 || style->hasFilter() 138 || style->hasFilter()
139 || style->hasBlendMode() 139 || style->hasBlendMode()
140 || style->hasIsolation() 140 || style->hasIsolation()
141 || style->position() == FixedPosition
142 || hasWillChangeThatCreatesStackingContext(style))) 141 || hasWillChangeThatCreatesStackingContext(style)))
143 style->setZIndex(0); 142 style->setZIndex(0);
144 143
145 // will-change:transform should result in the same rendering behavior as hav ing a transform, 144 // will-change:transform should result in the same rendering behavior as hav ing a transform,
146 // including the creation of a containing block for fixed position descendan ts. 145 // including the creation of a containing block for fixed position descendan ts.
147 if (!style->hasTransform() && (style->willChangeProperties().contains(CSSPro pertyWebkitTransform) || style->willChangeProperties().contains(CSSPropertyTrans form))) { 146 if (!style->hasTransform() && (style->willChangeProperties().contains(CSSPro pertyWebkitTransform) || style->willChangeProperties().contains(CSSPropertyTrans form))) {
148 bool makeIdentity = true; 147 bool makeIdentity = true;
149 style->setTransform(TransformOperations(makeIdentity)); 148 style->setTransform(TransformOperations(makeIdentity));
150 } 149 }
151 150
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 // clear how that should work. 249 // clear how that should work.
251 if (style->display() == INLINE && style->styleType() == NOPSEUDO && style->w ritingMode() != parentStyle->writingMode()) 250 if (style->display() == INLINE && style->styleType() == NOPSEUDO && style->w ritingMode() != parentStyle->writingMode())
252 style->setDisplay(INLINE_BLOCK); 251 style->setDisplay(INLINE_BLOCK);
253 252
254 if (parentStyle->isDisplayFlexibleOrGridBox()) { 253 if (parentStyle->isDisplayFlexibleOrGridBox()) {
255 style->setDisplay(equivalentBlockDisplay(style->display())); 254 style->setDisplay(equivalentBlockDisplay(style->display()));
256 } 255 }
257 } 256 }
258 257
259 } 258 }
OLDNEW
« no previous file with comments | « sky/engine/core/css/CSSPrimitiveValueMappings.h ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698