Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp

Issue 686633002: First pass at removing position:fixed. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.cpp ('k') | sky/engine/core/rendering/style/RenderStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp
diff --git a/sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp b/sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp
index 4577990e98c7f42c4b77f139f8114a0a5a4338ee..40c97e3163d41e44ae7083174cc22f19a272be26 100644
--- a/sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp
+++ b/sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp
@@ -33,18 +33,7 @@ static const RenderLayer* findParentLayerOnClippingContainerChain(const RenderLa
{
RenderObject* current = layer->renderer();
while (current) {
- if (current->style()->position() == FixedPosition) {
- for (current = current->parent(); current && !current->canContainFixedPositionObjects(); current = current->parent()) {
- // CSS clip applies to fixed position elements even for ancestors that are not what the
- // fixed element is positioned with respect to.
- if (current->hasClip()) {
- ASSERT(current->hasLayer());
- return static_cast<const RenderLayerModelObject*>(current)->layer();
- }
- }
- } else {
- current = current->containingBlock();
- }
+ current = current->containingBlock();
if (current->hasLayer())
return static_cast<const RenderLayerModelObject*>(current)->layer();
« no previous file with comments | « sky/engine/core/rendering/RenderView.cpp ('k') | sky/engine/core/rendering/style/RenderStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698