Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 685263004: Upgrade GPUOptimize (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Upgrade GPUOptimize This will be a bit hairy to review. The FillBounds and CollectLayers code has diverged significantly resulting in the rendering path seeing different bounds than the hoisting path. This CL merges the FillBounds changes into CollectLayers. A follow on CL will, hopefully, find a way to layer CollectLayers on top of FillBounds. The only code in CollectLayers that is different from FillBounds is bracketed by "LAYER HOISTING" comments. NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/d8aa7b74c8ef0cb8ed3f6b03beb7ee5013624372

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : update #

Patch Set 4 : cleanup #

Patch Set 5 : cleanup #

Patch Set 6 : clean up #

Patch Set 7 : update to ToT #

Patch Set 8 : minor fixes #

Patch Set 9 : Fix bug #

Patch Set 10 : clean up test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -92 lines) Patch
M include/core/SkPicture.h View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrPictureUtils.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 2 3 4 5 6 7 8 8 chunks +424 lines, -75 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 3 4 5 6 7 8 9 8 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
robertphillips
6 years, 1 month ago (2014-10-30 20:49:25 UTC) #2
bsalomon
lgtm. Definitely need to find a way to share the code that is the same ...
6 years, 1 month ago (2014-10-30 21:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685263004/180001
6 years, 1 month ago (2014-10-30 23:36:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685263004/180001
6 years, 1 month ago (2014-10-30 23:44:51 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 23:45:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as d8aa7b74c8ef0cb8ed3f6b03beb7ee5013624372

Powered by Google App Engine
This is Rietveld 408576698