Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 684763002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: void convertV8ObjectToNPVariant(v8::Local<v8::Value>, NPObject*, NPVariant*, v8::Isolate*) v8::Handle<v8::Value> convertNPVariantToV8Object(const NPVariant*, NPObject*, v8::Isolate*) static v8::Local<v8::String> npIdentifierToV8Identifier(NPIdentifier name, v8::Isolate* isolate)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M Source/bindings/core/v8/NPV8Object.cpp View 10 chunks +12 lines, -12 lines 0 comments Download
M Source/bindings/core/v8/V8NPObject.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8NPUtils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8NPUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebBindings.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
Please review. Thanks & Regards
6 years, 1 month ago (2014-10-28 06:52:10 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-28 07:09:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684763002/1
6 years, 1 month ago (2014-10-28 07:14:00 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 08:28:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184499

Powered by Google App Engine
This is Rietveld 408576698