Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: Source/bindings/core/v8/V8NPUtils.h

Issue 684763002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/V8NPObject.cpp ('k') | Source/bindings/core/v8/V8NPUtils.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 1 /* Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
2 * 2 *
3 * Redistribution and use in source and binary forms, with or without 3 * Redistribution and use in source and binary forms, with or without
4 * modification, are permitted provided that the following conditions are 4 * modification, are permitted provided that the following conditions are
5 * met: 5 * met:
6 * 6 *
7 * * Redistributions of source code must retain the above copyright 7 * * Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * * Redistributions in binary form must reproduce the above 9 * * Redistributions in binary form must reproduce the above
10 * copyright notice, this list of conditions and the following disclaimer 10 * copyright notice, this list of conditions and the following disclaimer
(...skipping 18 matching lines...) Expand all
29 29
30 #ifndef V8NPUtils_h 30 #ifndef V8NPUtils_h
31 #define V8NPUtils_h 31 #define V8NPUtils_h
32 32
33 #include <bindings/npruntime.h> 33 #include <bindings/npruntime.h>
34 #include <v8.h> 34 #include <v8.h>
35 35
36 namespace blink { 36 namespace blink {
37 37
38 // Convert a V8 Value of any type (string, bool, object, etc) to a NPVariant. 38 // Convert a V8 Value of any type (string, bool, object, etc) to a NPVariant.
39 void convertV8ObjectToNPVariant(v8::Local<v8::Value>, NPObject*, NPVariant*, v8: :Isolate*); 39 void convertV8ObjectToNPVariant(v8::Isolate*, v8::Local<v8::Value>, NPObject*, N PVariant*);
40 40
41 // Convert a NPVariant (string, bool, object, etc) back to a V8 Value. The owner object is the NPObject which relates to the 41 // Convert a NPVariant (string, bool, object, etc) back to a V8 Value. The owner object is the NPObject which relates to the
42 // object, if the object is an Object. The created NPObject will be tied to the lifetime of the owner. 42 // object, if the object is an Object. The created NPObject will be tied to the lifetime of the owner.
43 v8::Handle<v8::Value> convertNPVariantToV8Object(const NPVariant*, NPObject*, v8 ::Isolate*); 43 v8::Handle<v8::Value> convertNPVariantToV8Object(v8::Isolate*, const NPVariant*, NPObject*);
44 44
45 // Helper function to create an NPN String Identifier from a v8 string. 45 // Helper function to create an NPN String Identifier from a v8 string.
46 NPIdentifier getStringIdentifier(v8::Handle<v8::String>); 46 NPIdentifier getStringIdentifier(v8::Handle<v8::String>);
47 47
48 // The ExceptionHandler will be notified of any exceptions thrown while 48 // The ExceptionHandler will be notified of any exceptions thrown while
49 // operating on a NPObject. 49 // operating on a NPObject.
50 typedef void (*ExceptionHandler)(void* data, const NPUTF8* message); 50 typedef void (*ExceptionHandler)(void* data, const NPUTF8* message);
51 void pushExceptionHandler(ExceptionHandler, void* data); 51 void pushExceptionHandler(ExceptionHandler, void* data);
52 void popExceptionHandler(); 52 void popExceptionHandler();
53 53
54 // Upon destruction, an ExceptionCatcher will pass a caught exception to the 54 // Upon destruction, an ExceptionCatcher will pass a caught exception to the
55 // current ExceptionHandler. 55 // current ExceptionHandler.
56 class ExceptionCatcher { 56 class ExceptionCatcher {
57 public: 57 public:
58 ExceptionCatcher(); 58 ExceptionCatcher();
59 ~ExceptionCatcher(); 59 ~ExceptionCatcher();
60 private: 60 private:
61 v8::TryCatch m_tryCatch; 61 v8::TryCatch m_tryCatch;
62 }; 62 };
63 63
64 } // namespace blink 64 } // namespace blink
65 65
66 #endif // V8NPUtils_h 66 #endif // V8NPUtils_h
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8NPObject.cpp ('k') | Source/bindings/core/v8/V8NPUtils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698