Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: Source/web/WebBindings.cpp

Issue 684763002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8NPUtils.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebBindings.cpp
diff --git a/Source/web/WebBindings.cpp b/Source/web/WebBindings.cpp
index 6b2f5c9eaad4de6580c8194dc6243d684bd0032e..20e2e003dabfe21316712a073ba8c9c25231a42c 100644
--- a/Source/web/WebBindings.cpp
+++ b/Source/web/WebBindings.cpp
@@ -383,7 +383,7 @@ void WebBindings::popExceptionHandler()
void WebBindings::toNPVariant(v8::Local<v8::Value> object, NPObject* root, NPVariant* result)
{
- convertV8ObjectToNPVariant(object, root, result, v8::Isolate::GetCurrent());
+ convertV8ObjectToNPVariant(v8::Isolate::GetCurrent(), object, root, result);
}
v8::Handle<v8::Value> WebBindings::toV8Value(const NPVariant* variant)
@@ -394,11 +394,11 @@ v8::Handle<v8::Value> WebBindings::toV8Value(const NPVariant* variant)
V8NPObject* v8Object = npObjectToV8NPObject(object);
if (!v8Object)
return v8::Undefined(isolate);
- return convertNPVariantToV8Object(variant, v8Object->rootObject->frame()->script().windowScriptNPObject(), isolate);
+ return convertNPVariantToV8Object(isolate, variant, v8Object->rootObject->frame()->script().windowScriptNPObject());
}
// Safe to pass 0 since we have checked the script object class to make sure the
// argument is a primitive v8 type.
- return convertNPVariantToV8Object(variant, 0, isolate);
+ return convertNPVariantToV8Object(isolate, variant, 0);
}
} // namespace blink
« no previous file with comments | « Source/bindings/core/v8/V8NPUtils.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698