Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 684393002: Remove flipForWritingMode. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove flipForWritingMode. It's a noop now that we don't have writing modes. TBR=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2f4b26816693ee86520c15289d30df7e5d828047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -162 lines) Patch
M sky/engine/core/editing/Caret.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M sky/engine/core/rendering/InlineBox.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/InlineBox.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 5 chunks +1 line, -6 lines 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 9 chunks +9 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 6 chunks +5 lines, -77 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderLineBoxList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
6 years, 1 month ago (2014-10-30 02:45:01 UTC) #1
ojan
6 years, 1 month ago (2014-10-30 02:45:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f4b26816693ee86520c15289d30df7e5d828047.

Powered by Google App Engine
This is Rietveld 408576698