Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: sky/engine/core/rendering/RenderLayerClipper.cpp

Issue 684393002: Remove flipForWritingMode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 229
230 // If we establish an overflow clip at all, then go ahead and make sure our background 230 // If we establish an overflow clip at all, then go ahead and make sure our background
231 // rect is intersected with our layer's bounds including our visual over flow, 231 // rect is intersected with our layer's bounds including our visual over flow,
232 // since any visual overflow like box-shadow or border-outset is not cli pped by overflow:auto/hidden. 232 // since any visual overflow like box-shadow or border-outset is not cli pped by overflow:auto/hidden.
233 if (toRenderBox(m_renderer).hasVisualOverflow()) { 233 if (toRenderBox(m_renderer).hasVisualOverflow()) {
234 // FIXME: Perhaps we should be propagating the borderbox as the clip rect for children, even though 234 // FIXME: Perhaps we should be propagating the borderbox as the clip rect for children, even though
235 // we may need to inflate our clip specifically for shadows o r outsets. 235 // we may need to inflate our clip specifically for shadows o r outsets.
236 // FIXME: Does not do the right thing with CSS regions yet, since we don't yet factor in the 236 // FIXME: Does not do the right thing with CSS regions yet, since we don't yet factor in the
237 // individual region boxes as overflow. 237 // individual region boxes as overflow.
238 LayoutRect layerBoundsWithVisualOverflow = toRenderBox(m_renderer).v isualOverflowRect(); 238 LayoutRect layerBoundsWithVisualOverflow = toRenderBox(m_renderer).v isualOverflowRect();
239 toRenderBox(m_renderer).flipForWritingMode(layerBoundsWithVisualOver flow); // Layers are in physical coordinates, so the overflow has to be flipped.
240 layerBoundsWithVisualOverflow.moveBy(offset); 239 layerBoundsWithVisualOverflow.moveBy(offset);
241 if (!isClippingRoot || context.respectOverflowClip == RespectOverflo wClip) 240 if (!isClippingRoot || context.respectOverflowClip == RespectOverflo wClip)
242 backgroundRect.intersect(layerBoundsWithVisualOverflow); 241 backgroundRect.intersect(layerBoundsWithVisualOverflow);
243 } else { 242 } else {
244 LayoutRect bounds = toRenderBox(m_renderer).borderBoxRect(); 243 LayoutRect bounds = toRenderBox(m_renderer).borderBoxRect();
245 bounds.moveBy(offset); 244 bounds.moveBy(offset);
246 if (!isClippingRoot || context.respectOverflowClip == RespectOverflo wClip) 245 if (!isClippingRoot || context.respectOverflowClip == RespectOverflo wClip)
247 backgroundRect.intersect(bounds); 246 backgroundRect.intersect(bounds);
248 } 247 }
249 } 248 }
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 ASSERT(current); 341 ASSERT(current);
343 if (current->transform() || current->isPaintInvalidationContainer()) 342 if (current->transform() || current->isPaintInvalidationContainer())
344 return const_cast<RenderLayer*>(current); 343 return const_cast<RenderLayer*>(current);
345 } 344 }
346 345
347 ASSERT_NOT_REACHED(); 346 ASSERT_NOT_REACHED();
348 return 0; 347 return 0;
349 } 348 }
350 349
351 } // namespace blink 350 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderLayer.cpp ('k') | sky/engine/core/rendering/RenderLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698