Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: sky/engine/core/editing/Caret.cpp

Issue 684393002: Remove flipForWritingMode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/rendering/InlineBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/editing/Caret.cpp
diff --git a/sky/engine/core/editing/Caret.cpp b/sky/engine/core/editing/Caret.cpp
index e21ccc5a1649c5848f6a67cbd97093ff9565a622..b03f84e6d015cb8d0af20ce9423f9d0a08595cbf 100644
--- a/sky/engine/core/editing/Caret.cpp
+++ b/sky/engine/core/editing/Caret.cpp
@@ -190,10 +190,7 @@ IntRect CaretBase::absoluteBoundsForLocalRect(Node* node, const LayoutRect& rect
RenderBlock* caretPainter = caretRenderer(node);
if (!caretPainter)
return IntRect();
-
- LayoutRect localRect(rect);
- caretPainter->flipForWritingMode(localRect);
- return caretPainter->localToAbsoluteQuad(FloatRect(localRect)).enclosingBoundingBox();
+ return caretPainter->localToAbsoluteQuad(FloatRect(rect)).enclosingBoundingBox();
}
void CaretBase::invalidateLocalCaretRect(Node* node, const LayoutRect& rect)
@@ -238,8 +235,6 @@ void CaretBase::paintCaret(Node* node, GraphicsContext* context, const LayoutPoi
return;
LayoutRect drawingRect = localCaretRectWithoutUpdate();
- if (RenderBlock* renderer = caretRenderer(node))
- renderer->flipForWritingMode(drawingRect);
drawingRect.moveBy(roundedIntPoint(paintOffset));
LayoutRect caret = intersection(drawingRect, clipRect);
if (caret.isEmpty())
« no previous file with comments | « no previous file | sky/engine/core/rendering/InlineBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698