Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 684253002: Provide default implementations for NotificationDelegate methods. (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, pvalenzuela+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, peter+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Provide default implementations for NotificationDelegate methods. Many implementations of the NotificationDelegate include empty overrides because of behavior they don't actually need to be informed of. Provide empty default implementations so that they don't have to. (And remove the associated TODO.) BUG=428370 Committed: https://crrev.com/cf29ede833a3acda53607f9050612bafe52f2321 Cr-Commit-Position: refs/heads/master@{#302190}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -204 lines) Patch
M ash/display/resolution_notification_controller.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc View 3 chunks +2 lines, -19 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ash/system/locale/locale_notification_controller.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/notification_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_enrollment_handler.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification_unittest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/notifications/notification_test_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/status_icons/desktop_notification_balloon.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash.cc View 1 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/message_center/notification_delegate.h View 3 chunks +6 lines, -16 lines 0 comments Download
M ui/message_center/notification_delegate.cc View 4 chunks +10 lines, -28 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
Peter Beverloo
WDYT? Mike left a TODO about this, and given the large number of empty implementations ...
6 years, 1 month ago (2014-10-29 17:36:44 UTC) #2
dewittj
lgtm
6 years, 1 month ago (2014-10-29 17:51:30 UTC) #3
Peter Beverloo
+stevenjb for ash/system/ +thestig for chrome/
6 years, 1 month ago (2014-10-29 20:04:22 UTC) #5
stevenjb
ash/system lgtm
6 years, 1 month ago (2014-10-29 20:06:21 UTC) #6
Lei Zhang
chrome/ lgtm
6 years, 1 month ago (2014-10-29 22:20:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684253002/1
6 years, 1 month ago (2014-10-30 09:52:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21191) linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/7458)
6 years, 1 month ago (2014-10-30 09:55:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684253002/20001
6 years, 1 month ago (2014-10-30 11:33:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21204)
6 years, 1 month ago (2014-10-30 11:36:58 UTC) #15
Peter Beverloo
+mukai for ash/display/
6 years, 1 month ago (2014-10-30 12:42:07 UTC) #16
Peter Beverloo
+James for ash/display stamp? :-)
6 years, 1 month ago (2014-10-30 22:00:19 UTC) #18
Daniel Erat
lgtm for ash/display
6 years, 1 month ago (2014-10-30 22:20:48 UTC) #20
Peter Beverloo
On 2014/10/30 22:20:48, Daniel Erat wrote: > lgtm for ash/display Thanks Daniel!
6 years, 1 month ago (2014-10-30 22:34:19 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684253002/20001
6 years, 1 month ago (2014-10-30 22:36:09 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 23:19:31 UTC) #24
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 23:20:23 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf29ede833a3acda53607f9050612bafe52f2321
Cr-Commit-Position: refs/heads/master@{#302190}

Powered by Google App Engine
This is Rietveld 408576698